linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] spi: omap2: use SUPERH, not SH
@ 2014-02-08 21:01 Paul Bolle
  2014-02-08 21:19 ` Geert Uytterhoeven
  2014-02-10 12:34 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Bolle @ 2014-02-08 21:01 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, linux-kernel

Commit 0079aae0f1e6 ("spi: omap2: Add build dependencies for
writel_relaxed()") added an optional Kconfig dependency on SH. That
Kconfig symbol doesn't exist. Apparently SUPERH was intended. Use that.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Basically untested.

 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index ba9310b..205dbfe 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -307,7 +307,7 @@ config SPI_OMAP_UWIRE
 
 config SPI_OMAP24XX
 	tristate "McSPI driver for OMAP"
-	depends on ARM || ARM64 || AVR32 || HEXAGON || MIPS || SH
+	depends on ARM || ARM64 || AVR32 || HEXAGON || MIPS || SUPERH
 	depends on ARCH_OMAP2PLUS || COMPILE_TEST
 	help
 	  SPI master controller for OMAP24XX and later Multichannel SPI
-- 
1.8.5.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: omap2: use SUPERH, not SH
  2014-02-08 21:01 [PATCH] spi: omap2: use SUPERH, not SH Paul Bolle
@ 2014-02-08 21:19 ` Geert Uytterhoeven
  2014-02-10 12:34 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-02-08 21:19 UTC (permalink / raw)
  To: Paul Bolle
  Cc: Mark Brown, linux-spi,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Sat, Feb 8, 2014 at 10:01 PM, Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> wrote:
> Commit 0079aae0f1e6 ("spi: omap2: Add build dependencies for
> writel_relaxed()") added an optional Kconfig dependency on SH. That
> Kconfig symbol doesn't exist. Apparently SUPERH was intended. Use that.
>
> Signed-off-by: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>

Nice catch!

Acked-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>

BTW, MICROBLAZE can be added as well. It got writel_relaxed() in
v3.14-rc1.

> ---
> Basically untested.
>
>  drivers/spi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index ba9310b..205dbfe 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -307,7 +307,7 @@ config SPI_OMAP_UWIRE
>
>  config SPI_OMAP24XX
>         tristate "McSPI driver for OMAP"
> -       depends on ARM || ARM64 || AVR32 || HEXAGON || MIPS || SH
> +       depends on ARM || ARM64 || AVR32 || HEXAGON || MIPS || SUPERH
>         depends on ARCH_OMAP2PLUS || COMPILE_TEST
>         help
>           SPI master controller for OMAP24XX and later Multichannel SPI

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: omap2: use SUPERH, not SH
  2014-02-08 21:01 [PATCH] spi: omap2: use SUPERH, not SH Paul Bolle
  2014-02-08 21:19 ` Geert Uytterhoeven
@ 2014-02-10 12:34 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-02-10 12:34 UTC (permalink / raw)
  To: Paul Bolle
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

On Sat, Feb 08, 2014 at 10:01:21PM +0100, Paul Bolle wrote:
> Commit 0079aae0f1e6 ("spi: omap2: Add build dependencies for
> writel_relaxed()") added an optional Kconfig dependency on SH. That
> Kconfig symbol doesn't exist. Apparently SUPERH was intended. Use that.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-02-10 12:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 21:01 [PATCH] spi: omap2: use SUPERH, not SH Paul Bolle
2014-02-08 21:19 ` Geert Uytterhoeven
2014-02-10 12:34 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).