From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Ryo Kataoka <ryo.kataoka.wt@renesas.com>,
Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
Subject: Re: [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC
Date: Wed, 6 Sep 2017 12:42:30 +0200 [thread overview]
Message-ID: <CAMuHMdXimyHd3Egy0tja2Zst-8Ok_BwdTv7fg1_eYSb1j5XBjA@mail.gmail.com> (raw)
In-Reply-To: <df19487c-14e3-75e5-521c-0140768b1f9d@de.bosch.com>
Hi Dirk,
On Wed, Sep 6, 2017 at 12:09 PM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
> On 06.09.2017 11:22, Geert Uytterhoeven wrote:
>> On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme <dirk.behme@de.bosch.com>
>> wrote:
>>>
>>> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>>
>>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
>>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.
>>>
>>> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>>> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@renesas.com>
>>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>>
>>
>> NAKed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> The MSIOF Base Address for DMAC was removed only from the R-Car Gen2/Gen3
>> manuals. It still affects e.g. R-Mobile APE6.
>
> Do we have a nice run time detection for that?
The current driver code just looks at the DTS, cfr. the comment:
/* The DMA engine uses the second register set, if present */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-09-06 10:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 7:04 [PATCH 0/8] spi: sh-msiof: Import some BSP patches Dirk Behme
2017-09-06 7:05 ` [PATCH 1/8] spi: sh-msiof: Add sleep before master transfer for test Dirk Behme
[not found] ` <20170906070507.26223-2-dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-07 7:04 ` Vladimir Zapolskiy
[not found] ` <f355b733-68cd-d252-2972-87d3efbedf75-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2017-09-07 7:16 ` Dirk Behme
2017-09-07 8:11 ` Geert Uytterhoeven
[not found] ` <CAMuHMdV5vQsS5RgykMptRxDb1wgS9YryBQu7xgGHXactjGGWFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-07 8:26 ` Dirk Behme
2017-09-06 7:05 ` [PATCH 2/8] spi: sh-msiof: Fix DMA transfer size check Dirk Behme
2017-09-07 8:31 ` Geert Uytterhoeven
2017-09-07 8:33 ` Dirk Behme
[not found] ` <931484ec-8830-0e63-98cb-9dd58ce35230-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-07 8:39 ` Geert Uytterhoeven
2017-09-07 8:42 ` Dirk Behme
2017-09-07 8:59 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVo_62kYYmgLZNHksRi+Z96K+tu9KTsgyKfmk6U_gP79w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-07 9:05 ` Dirk Behme
[not found] ` <a3fbaa5c-caa1-c28f-3248-6c5557a96d8c-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-07 9:12 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXQKj3F02zur3BZ95Et+btQD=rOfpMUC8cFWBnwF4Qxdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 17:25 ` Geert Uytterhoeven
2018-01-04 7:19 ` Dirk Behme
2018-01-04 8:24 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 4/8] spi: sh-msiof: Fix DMA completion Dirk Behme
[not found] ` <20170906070507.26223-5-dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-07 8:33 ` Geert Uytterhoeven
[not found] ` <CAMuHMdW=AA03BLMXO8EpBBx3gdd13VPrjhL1gsEgZR2msYBkcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-07 8:41 ` Dirk Behme
2017-09-06 7:05 ` [PATCH 5/8] spi: sh-msiof: Wait for Tx FIFO empty after DMA Dirk Behme
2017-09-06 17:57 ` Sergei Shtylyov
[not found] ` <20170906070507.26223-6-dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-07 8:34 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 6/8] spi: sh-msiof: Add MSIOF parent clock changing function for R-Car Gen3 Dirk Behme
2017-09-07 8:38 ` Geert Uytterhoeven
[not found] ` <20170906070507.26223-1-dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-06 7:05 ` [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC Dirk Behme
2017-09-06 9:22 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXu6t5StNB8jy2uGiJ1YLuQEHO7Kz4+PoihkaZnmLe8YA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-06 10:09 ` Dirk Behme
2017-09-06 10:42 ` Geert Uytterhoeven [this message]
[not found] ` <CAMuHMdXimyHd3Egy0tja2Zst-8Ok_BwdTv7fg1_eYSb1j5XBjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-06 10:59 ` Dirk Behme
2017-09-06 11:01 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 7/8] spi: sh-msiof: Fix gpio function Dirk Behme
2017-09-07 8:24 ` Geert Uytterhoeven
2017-09-06 7:05 ` [PATCH 8/8] spi: sh-msiof: Add registers reset Dirk Behme
2017-09-06 18:11 ` Sergei Shtylyov
[not found] ` <20170906070507.26223-9-dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2017-09-07 8:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXimyHd3Egy0tja2Zst-8Ok_BwdTv7fg1_eYSb1j5XBjA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=dirk.behme@de.bosch.com \
--cc=geert+renesas@glider.be \
--cc=hiromitsu.yamasaki.ym@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ryo.kataoka.wt@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).