From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC Date: Wed, 6 Sep 2017 12:42:30 +0200 Message-ID: References: <20170906070507.26223-1-dirk.behme@de.bosch.com> <20170906070507.26223-4-dirk.behme@de.bosch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Linux-Renesas , linux-spi , Geert Uytterhoeven , Ryo Kataoka , Hiromitsu Yamasaki To: Dirk Behme Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org Hi Dirk, On Wed, Sep 6, 2017 at 12:09 PM, Dirk Behme wrote: > On 06.09.2017 11:22, Geert Uytterhoeven wrote: >> On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme >> wrote: >>> >>> From: Ryo Kataoka >>> >>> MSIOF Base Address H'E6xx can be accessed by CPU and DMAC. >>> MSIOF Base Address H'E7xx for DMAC was removed from H/W manual. >>> >>> Signed-off-by: Ryo Kataoka >>> Signed-off-by: Hiromitsu Yamasaki >>> Signed-off-by: Dirk Behme >> >> >> NAKed-by: Geert Uytterhoeven >> >> The MSIOF Base Address for DMAC was removed only from the R-Car Gen2/Gen3 >> manuals. It still affects e.g. R-Mobile APE6. > > Do we have a nice run time detection for that? The current driver code just looks at the DTS, cfr. the comment: /* The DMA engine uses the second register set, if present */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds