From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B55FC2D0FD for ; Wed, 13 May 2020 07:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 09FC82492A for ; Wed, 13 May 2020 07:12:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="K5pzuy/Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731821AbgEMHM0 (ORCPT ); Wed, 13 May 2020 03:12:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730444AbgEMHM0 (ORCPT ); Wed, 13 May 2020 03:12:26 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8E8FC061A0E for ; Wed, 13 May 2020 00:12:25 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id a21so16497147ljj.11 for ; Wed, 13 May 2020 00:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IRFk30OEdsBaX3lNynkWDdT0LAUKPWkllb6vWrvUfFU=; b=K5pzuy/Q0DbKRQJhtwBbIhHrErl3UFCylyh40MxEmVKtgp7yEA96J6jzDlnp1Z9lX3 L0095lu9fUxrCVlwBbN8u7k/YjU5gQNhOooEFNtUQuKet6vVAPI48KqdvwDDSoWxkmNw +PylWBmbq3ADzq9SmaUFmuSSxZT6qEFLq+V/2QzC90vcKfu7ZAw7q1+eCKk985st/+rD L0WnmVbg1Zay9q2IAo3SswAhLrVPrbQyjbJyS5GnZ/rQoLHTPXPjoZLTn/MHOb9BorNj TxoihN27LfVVuTTxxgi5ohtgAfasA7G6w5fuCLWotsAmKVh4quhdqPwl8wkOmMx30QtM 4TuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IRFk30OEdsBaX3lNynkWDdT0LAUKPWkllb6vWrvUfFU=; b=pSrQuRB/Z6AXutMJlumTZ6sFyMfKC080RWGlYooZwqwJTv2XF+g4bPAeLckDPWdjpo YStGhqfeXUD8gxeJCKpn5S3a/hfKo68HvCp9S095bD/TMeGP53z4gEffgsihWNKrAv/5 zZEdpZTEnARwA0GZOWHWensDORwU5410NR0WJUvZudd2w1sLJm4V9dRBtDos+sgrd/fW NUWgiGOknk0fOnCXpFf1E3XixDKHxyUJ3uWqbNzJAgpcG5yTGG/7V0DajNmL6IHofB7U qJZD6C9pzjTD+rWsMhyeTPhz1ZdF6/IMG16i6nxKZDUCdx1+xwBMi+s29bw/K5Pevf6t CPRA== X-Gm-Message-State: AOAM5312pUQvnz3165kkTG64v+BpkuGZvFyGZhkNt9XLOPKQvIpFEXsD MUrziGcyoMSIRR1Fm7vPA4wxwBX/K2zxLgBjOKZlKw== X-Google-Smtp-Source: ABdhPJxOVv0j3JItO5IlLO900Ue/XycQksnMkwQAPd8Io9f7MPELoXRwn0ku6xHMSL2Omjmun1aVBi7/j3xnmT3aaQ4= X-Received: by 2002:a2e:8e98:: with SMTP id z24mr16710225ljk.134.1589353944120; Wed, 13 May 2020 00:12:24 -0700 (PDT) MIME-Version: 1.0 References: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com> <1589218356-17475-4-git-send-email-yibin.gong@nxp.com> <20200513060525.GJ5877@pengutronix.de> In-Reply-To: <20200513060525.GJ5877@pengutronix.de> From: "Fuzzey, Martin" Date: Wed, 13 May 2020 09:12:13 +0200 Message-ID: Subject: Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache" To: Sascha Hauer Cc: Robin Gong , vkoul@kernel.org, Shawn Guo , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Rob Herring , Fabio Estevam , dan.j.williams@intel.com, mark.rutland@arm.com, catalin.marinas@arm.com, Will Deacon , Lucas Stach , Sascha Hauer , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Linux-Kernel@Vger. Kernel. Org" , dl-linux-imx , dmaengine@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Wed, 13 May 2020 at 08:07, Sascha Hauer wrote: > > On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote: > > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since > > 'context_loaded' finally removed. > > > > Signed-off-by: Robin Gong > > --- > > I think this can safely be folded into the next patch which makes it > more clear what is happening. > Agreed, not only that but having 2 separate patches also means that the bug that was fixed by the commit being reverted could reappear during bisection. More generally I think reverts should be reserved for commits that later turn out to be wrong or unneeded (ie should never really have been applied). If they were OK at the time but later become unnecessary due to other code changes I think all the related modifications should be done in a single normal non revert patch. Martin