linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
	Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>,
	Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Stefano Babic <sbabic-ynQEQJNshbs@public.gmane.org>,
	spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Dong Aisheng <b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 8/8] mmc: spi: Add DMA support into SPI driver
Date: Fri, 29 Jun 2012 10:49:23 -0300	[thread overview]
Message-ID: <CAOMZO5AN852f3Awv0UG+ApsgMC-x5ByQrLkUC5SkOnty5T0EMA@mail.gmail.com> (raw)
In-Reply-To: <1340958180-2291-8-git-send-email-marex-ynQEQJNshbs@public.gmane.org>

Hi Marek,

On 6/29/12, Marek Vasut <marex-ynQEQJNshbs@public.gmane.org> wrote:

>  	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!iores)
> +	dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0);
> +	irq_err = platform_get_irq(pdev, 0);
> +	irq_dma = platform_get_irq(pdev, 1);
> +	if (!iores || irq_err < 0 || irq_dma < 0)

Shouldn't you check for dmares < 0 here too?

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

  parent reply	other threads:[~2012-06-29 13:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29  8:22 [PATCH 1/8] mmc: spi: Move SSP register definitions into separate file Marek Vasut
     [not found] ` <1340958180-2291-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-06-29  8:22   ` [PATCH 2/8] mmc: spi: Rename IMX2[38]_MMC to IMX2[38]_SSP Marek Vasut
2012-06-29  8:22   ` [PATCH 3/8] mmc: spi: Add necessary bits into mxs-spi.h Marek Vasut
2012-06-29  8:22   ` [PATCH 4/8] mmc: spi: Pull out parts shared between MMC and SPI Marek Vasut
2012-06-29  8:22   ` [PATCH 5/8] mmc: spi: Pull out the SSP clock configuration function Marek Vasut
2012-06-29  8:22   ` [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28 Marek Vasut
2012-07-05  0:51     ` Shawn Guo
     [not found]       ` <20120705005143.GF2595-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-07-05  5:39         ` Marek Vasut
2012-07-05  5:43           ` Shawn Guo
     [not found]             ` <CAAQ0ZWQEoOy6etXhsy3uTPmiFqtVaqMf5VXUHFrp3O6R_jQ06g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-05  5:46               ` Marek Vasut
2012-07-05  5:51                 ` Shawn Guo
     [not found]                   ` <CAAQ0ZWQ-eQaN=R4ZoEeAD3yk+tBb7QQHdUHpOd0YeeYmkyi1kA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-05  6:00                     ` Marek Vasut
2012-06-29  8:22   ` [PATCH 7/8] mmc: spi: Pull out common DMA parts from MXS MMC Marek Vasut
2012-06-29  8:23   ` [PATCH 8/8] mmc: spi: Add DMA support into SPI driver Marek Vasut
     [not found]     ` <1340958180-2291-8-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-06-29 13:49       ` Fabio Estevam [this message]
     [not found]         ` <CAOMZO5AN852f3Awv0UG+ApsgMC-x5ByQrLkUC5SkOnty5T0EMA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-04 21:40           ` Marek Vasut
     [not found]             ` <201207042340.55301.marex-ynQEQJNshbs@public.gmane.org>
2012-07-04 21:43               ` Fabio Estevam
2012-07-04 23:20               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AN852f3Awv0UG+ApsgMC-x5ByQrLkUC5SkOnty5T0EMA@mail.gmail.com \
    --to=festevam-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=b29396-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
    --cc=dzu-ynQEQJNshbs@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=sbabic-ynQEQJNshbs@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=wd-ynQEQJNshbs@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).