From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Suchanek Subject: Re: [PATCH 2/3] spidev: Add DT binding example. Date: Tue, 28 Apr 2015 22:43:37 +0200 Message-ID: References: <12F80B18-7418-430E-94F7-5A20C133BA9A@martin.sperl.org> <20150426125113.GF5627@lukather> <20150427101601.GN22845@sirena.org.uk> <20150427173036.GA10950@lukather> <20150427180728.GW22845@sirena.org.uk> <20150428141630.GR22845@sirena.org.uk> <20150428171738.GY22845@sirena.org.uk> Reply-To: hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "Eric D." , linux-sunxi , Jonathan Corbet , Hans de Goede , Linux Kernel Mailing List , Maxime Ripard , linux-spi , Martin Sperl To: Mark Brown Return-path: In-Reply-To: <20150428171738.GY22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-spi.vger.kernel.org On 28 April 2015 at 19:17, Mark Brown wrote: > On Tue, Apr 28, 2015 at 04:22:24PM +0200, Michal Suchanek wrote: >> On 28 April 2015 at 16:16, Mark Brown wrote: > >> > That is not the case as you well know. As has been said several times >> > the compatible for the device should be added to the match table in >> > spidev.c. > >> That's a way unusable for people who actually want to use spidev so it >> might be TheApprovedWay(tm) but not RightWay(tm). > > I'm pretty sure that someone who's able to edit one file can edit two. > I know you have a viewpoint on this but engaging in this way is not > helping anyone. The point is that patching the kernel to use spidev is totally useless complication which is brought on spidev users by obtuse kernel maintainers. This patch applied to a kernel which is distributed with the board solves the problem for all spidev users of the board which TheApprovedWay(tm) does not. Thanks Michal