From: Ulf Hansson <ulf.hansson@linaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: linux-mmc@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
cyril.jean@microchip.com, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [RFC v1 1/3] mmc: mmc_spi: allow for spi controllers incapable of getting as low as 400k
Date: Thu, 20 Jun 2024 16:24:49 +0200 [thread overview]
Message-ID: <CAPDyKFre12rqqwar8sfoWyc6duS3psp4OT=W5ToG9r_EdqH89w@mail.gmail.com> (raw)
In-Reply-To: <20240620-sabbath-ambulance-b8764fb386e9@spud>
On Thu, 20 Jun 2024 at 16:12, Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Jun 20, 2024 at 02:50:15PM +0200, Ulf Hansson wrote:
> > On Wed, 12 Jun 2024 at 17:48, Conor Dooley <conor@kernel.org> wrote:
> > >
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > >
> > > Some controllers may not be able to reach a bus clock as low as 400 KHz
> > > due to a lack of sufficient divisors. In these cases, the SD card slot
> > > becomes non-functional as Linux continuously attempts to set the bus
> > > clock to 400 KHz. If the controller is incapable of getting that low,
> > > set its minimum frequency instead. While this may eliminate some SD
> > > cards, it allows those capable of operating at the controller's minimum
> > > frequency to be used.
> > >
> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > Looks reasonable to me. I assume you intend to send a non-RFC for
> > this, that I can pick up?
>
> I do intend doing that. How soon depends on whether or not you are
> willing to take it on its own, or require it to come in a series with
> the spi driver changes.
I can pick it separately, if that makes sense to you.
Kind regards
Uffe
next prev parent reply other threads:[~2024-06-20 14:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:48 [RFC v1 0/3] mmc-spi - support controllers incapable of getting as low as 400KHz Conor Dooley
2024-06-12 15:48 ` [RFC v1 1/3] mmc: mmc_spi: allow for spi controllers incapable of getting as low as 400k Conor Dooley
2024-06-20 12:50 ` Ulf Hansson
2024-06-20 14:12 ` Conor Dooley
2024-06-20 14:24 ` Ulf Hansson [this message]
2024-06-12 15:48 ` [RFC v1 2/3] spi: microchip-core-qspi: Add regular transfers Conor Dooley
2024-06-12 16:40 ` Mark Brown
2024-06-12 20:48 ` Conor Dooley
2024-06-19 11:18 ` Conor Dooley
2024-06-12 15:48 ` [RFC v1 3/3] spi: microchip-core-qspi: set min_speed_hz during probe Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFre12rqqwar8sfoWyc6duS3psp4OT=W5ToG9r_EdqH89w@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=cyril.jean@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).