From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2408719F48D for ; Mon, 24 Jun 2024 17:47:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719251281; cv=none; b=jP4jYPG4xHDVwODodtpqg2F8QkXeg3PumIPNC154i7tHsSR0eW2ioC1MrBpHhNBpb3XFIqD5uudshHspE+arrIT4pgVMS0NUE/xsXTk1NxdhbYypaNUqdZyyZ/7iQjPXhhQ0sQkgGnJFhhirHVClKWqqloausVgsQ55IvSOcxT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719251281; c=relaxed/simple; bh=P1jGE0yj+W9MBcCc+1zGVoDh+/I8AA93BhngLeHVOT8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Kq34c6s7cbKfaryTGXagWVL/bXCpwbWv1rsD0cq0e5IxXECfo0CMGZuvTRYY2SfX4jgnYI5RTK88VkWFWQP83hHWY9RO014UMJzqRu0UEeM8FYxeoK3AM0bc52BR+XUcuvGeiYoAan0ndMSYU6ogHuo6zCG4CBXMPjHaXbNC1vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=Rh/zq9wI; arc=none smtp.client-ip=209.85.219.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Rh/zq9wI" Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-dfe1aa7cce2so4313046276.1 for ; Mon, 24 Jun 2024 10:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1719251278; x=1719856078; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GD6JszPohU81NGGS/aKdIrLNqexC1KvwW9h5dgcZ2tY=; b=Rh/zq9wItMzkrJJuiqb+MSt3M5QW+41ZoEoUXas+4gioNtQwzsK3SIYcxhJL3rNSJF TQR2cdKS+zUzwj3x7bxg8YYZQgy0IZRUYpfrLV7OICmCQygCwBS6xzaRXMOXXXi3vaqM Mno0Cc1eje/5fGObXUHPsL47Y8mRnsEr+BM28Ev/ZLtr1IUfNcUp2ZXu545AK52TgVE7 LRYHyTvjwB2wTgh2u814jzx+8/zMGUdJ+05llRDB1UQWuga70Yyi8DzLOKX3A9bnMB34 yPExxQWM9vRZgxLwjalGzLzmjOPXtQ5liu3j22/c4IZmw/lVmPyGH4Dy4jtaDyzY6fIU yEoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719251278; x=1719856078; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GD6JszPohU81NGGS/aKdIrLNqexC1KvwW9h5dgcZ2tY=; b=NG3PM1mPGifGuHXnMIksszMnQadQZ+BIao73z+25sSKYqBDStfOitLgssn4vEZWSUT hjYlrpjschDgTGhJbh4Z4ma+Zv9+t8C5pIlxo4s/qbZNLbR/BxAa5JYBWj25CFmYVZRv VKeQmeR+Df0Ec6JNzo/5iDx6piFciVxIp4Trtbhe07bcCM6TPKA5530n5V6l70jS/StX O7aiEQCItS3f0I01URrDhuZ0SIrwnZCZV3cp/nilZKnbrxwA7WHrw6ZsTr2n8BXZlK2E ZbTx3hHfL2R9tBx6rop02K6prxbn6RJAuSY7t1Gj+QpqgQB4035lxbiLj0v8xVBVxC6X piXg== X-Forwarded-Encrypted: i=1; AJvYcCV7As9lbVeBPVhZtGw0OrDlqJuufDmGRQGH3ouzkOfVhN6ZgNNxIASS1u3gug1fI4AkUrYp2ZjhGSM/5Au8u/Rp9tak4kbXW8Vn X-Gm-Message-State: AOJu0YxrqwrSyoC1S21gdW+HL5jWvnZ3JxLtu5KDQqx9GN2/MTcJKdFX 8hhUwXbgKPSEUB6dNtQH9SArnCGqmFdpLXUwr8cgwQFIX/QxxZT3GgCpu9Y8k1vBX3qiUzrloKK ftvnOJ5stZ139zmHWTpUDDmwn9NCJyfHAYR/0Aw== X-Google-Smtp-Source: AGHT+IEam62Ke7h6aMEIOfZkOn8q0O/x65GpW/b4zmed/2bsjgtR1QeT3Q2l3hKiUKoRuWDKy+pcqMjQukMAFKYFW9Y= X-Received: by 2002:a25:291:0:b0:df4:f2d2:fcd6 with SMTP id 3f1490d57ef6-e0303fe9b62mr4805338276.44.1719251277992; Mon, 24 Jun 2024 10:47:57 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240524182702.1317935-1-dave.stevenson@raspberrypi.com> <20240524182702.1317935-7-dave.stevenson@raspberrypi.com> In-Reply-To: From: Dave Stevenson Date: Mon, 24 Jun 2024 18:47:41 +0100 Message-ID: Subject: Re: [PATCH 06/18] dmaengine: bcm2835: make address increment platform independent To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Vinod Koul , Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Ulf Hansson , Mark Brown , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Vladimir Murzin , Phil Elwell , Stefan Wahren , Serge Semin , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, iommu@lists.linux.dev, linux-sound@vger.kernel.org, Stefan Wahren Content-Type: text/plain; charset="UTF-8" Hi Frank Thanks for the review, and sorry for the delay in coming back to this. On Wed, 5 Jun 2024 at 18:53, Frank Li wrote: > > On Fri, May 24, 2024 at 07:26:50PM +0100, Dave Stevenson wrote: > > From: Stefan Wahren > > > > Actually the criteria to increment source & destination address doesn't > > based on platform specific bits. It's just the DMA transfer direction which > > is translated into the info bits. So introduce two new helper functions > > and get the rid of these platform specifics. > > > > Fix increment source & destination address depend on the platform drvdata. This is not platform drvdata. The code was converting from the generic DMA transfer direction enum into the hardware specific bitmask, and then looking at that for whether it was using an address increment or not. It's more readable, and easier to add in the newer variant of the hardware, if we check the generic transfer direction. I've reworded it for V2 as "The criteria for whether an address increment is required is based solely on the DMA transfer direction. The driver was converting from direction into the hardware's "info" bitmask and using that, which is therefore dependent on the hardware variant. Change to using the DMA transfer direction via helper functions to remove this hardware specific dependency." Hopefully makes the situation clearer. > It should be depend on dma_transfer_direction. > > look like it is bug fixes. Can you add fixes tag. No, as described above, it's not a bug fix. Dave > > Signed-off-by: Stefan Wahren > > Signed-off-by: Dave Stevenson > > --- > > drivers/dma/bcm2835-dma.c | 28 ++++++++++++++++++++++------ > > 1 file changed, 22 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c > > index ef452ebb3c15..d6c5a2762a46 100644 > > --- a/drivers/dma/bcm2835-dma.c > > +++ b/drivers/dma/bcm2835-dma.c > > @@ -252,6 +252,24 @@ static u32 bcm2835_dma_prepare_cb_extra(struct bcm2835_chan *c, > > return result; > > } > > > > +static inline bool need_src_incr(enum dma_transfer_direction direction) > > +{ > > + return direction != DMA_DEV_TO_MEM; > > +} > > + > > +static inline bool need_dst_incr(enum dma_transfer_direction direction) > > +{ > > + switch (direction) { > > + case DMA_MEM_TO_MEM: > > + case DMA_DEV_TO_MEM: > > + return true; > > + default: > > + break; > > + } > > + > > + return false; > > +} > > + > > static void bcm2835_dma_free_cb_chain(struct bcm2835_desc *desc) > > { > > size_t i; > > @@ -336,10 +354,8 @@ static inline size_t bcm2835_dma_count_frames_for_sg( > > * @cyclic: it is a cyclic transfer > > * @info: the default info bits to apply per controlblock > > * @frames: number of controlblocks to allocate > > - * @src: the src address to assign (if the S_INC bit is set > > - * in @info, then it gets incremented) > > - * @dst: the dst address to assign (if the D_INC bit is set > > - * in @info, then it gets incremented) > > + * @src: the src address to assign > > + * @dst: the dst address to assign > > * @buf_len: the full buffer length (may also be 0) > > * @period_len: the period length when to apply @finalextrainfo > > * in addition to the last transfer > > @@ -408,9 +424,9 @@ static struct bcm2835_desc *bcm2835_dma_create_cb_chain( > > d->cb_list[frame - 1].cb->next = cb_entry->paddr; > > > > /* update src and dst and length */ > > - if (src && (info & BCM2835_DMA_S_INC)) > > + if (src && need_src_incr(direction)) > > src += control_block->length; > > - if (dst && (info & BCM2835_DMA_D_INC)) > > + if (dst && need_dst_incr(direction)) > > dst += control_block->length; > > > > /* Length of total transfer */ > > -- > > 2.34.1 > >