From: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Cc: "Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Michal Simek"
<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
"Sören Brinkmann"
<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] spi: xilinx: Return IRQ_NONE if no interrupts were detected
Date: Tue, 12 Jul 2016 15:31:42 +0200 [thread overview]
Message-ID: <CAPybu_03qa8bAX8PFtwmCe-bnD+6GSdMuB71r_Z0ShisR+Civg@mail.gmail.com> (raw)
In-Reply-To: <1468329881-5894-2-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Acked-by: Ricardo Ribalda Delgado <ricardo.ribalda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, Jul 12, 2016 at 3:24 PM, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> wrote:
> Return IRQ_NONE from the interrupt handler if the handler is running, but
> no interrupt was detected. This allows the system to recover in case of an
> interrupt storm due to an invalid interrupt configuration or faulty
> hardware.
>
> Signed-off-by: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
> ---
> drivers/spi/spi-xilinx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 334f423..f8280f3 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -341,9 +341,10 @@ static irqreturn_t xilinx_spi_irq(int irq, void *dev_id)
>
> if (ipif_isr & XSPI_INTR_TX_EMPTY) { /* Transmission completed */
> complete(&xspi->done);
> + return IRQ_HANDLED;
> }
>
> - return IRQ_HANDLED;
> + return IRQ_NONE;
> }
>
> static int xilinx_spi_find_buffer_size(struct xilinx_spi *xspi)
> --
> 2.1.4
>
--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-12 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 13:24 [PATCH 1/2] spi: xilinx: Handle errors from platform_get_irq() Lars-Peter Clausen
[not found] ` <1468329881-5894-1-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-07-12 13:24 ` [PATCH 2/2] spi: xilinx: Return IRQ_NONE if no interrupts were detected Lars-Peter Clausen
[not found] ` <1468329881-5894-2-git-send-email-lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2016-07-12 13:31 ` Ricardo Ribalda Delgado [this message]
2016-07-15 11:57 ` Applied "spi: xilinx: Return IRQ_NONE if no interrupts were detected" to the spi tree Mark Brown
2016-07-12 13:31 ` [PATCH 1/2] spi: xilinx: Handle errors from platform_get_irq() Ricardo Ribalda Delgado
2016-07-12 13:48 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPybu_03qa8bAX8PFtwmCe-bnD+6GSdMuB71r_Z0ShisR+Civg@mail.gmail.com \
--to=ricardo.ribalda-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).