From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 2/2] clkdev: Export clk_register_clkdev Date: Mon, 02 Jun 2014 08:16:08 -0700 Message-ID: References: <1401738379-4107-1-git-send-email-chiau.ee.chew@intel.com> <1401738379-4107-3-git-send-email-chiau.ee.chew@intel.com> <20140602123522.GB31751@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: Eric Miao , Russell King , Haojian Zhuang , Grant Likely , Rob Herring , Mika Westerberg , LKML , , , To: Mark Brown , Chew Chiau Ee Return-path: In-Reply-To: <20140602123522.GB31751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-spi.vger.kernel.org On 6/2/14, 5:35, "Mark Brown" wrote: >On Tue, Jun 03, 2014 at 03:46:19AM +0800, Chew Chiau Ee wrote: >> From: Darren Hart >> >> Allow spi-pxa2xx-pci with common clock framework support to build as a >> module by exporting clk_register_clkdev. > >This needs to be patch 1 in the series not patch 2 since the change to >the driver to use the exported symbol depends on this rather than the >other way around. > That was going to be my only comment as well. It's important to ensure things build consistently through the git history. Git bisect is a key use case here, breaking that makes for very cranky kernel engineers :-) Dependencies first, new mechanisms second. -- Darren Hart Open Source Technology Center darren.hart-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html