From: "Michael Walle" <mwalle@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"AlvinZhou" <alvinzhou.tw@gmail.com>,
<linux-mtd@lists.infradead.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <pratyush@kernel.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<broonie@kernel.org>
Cc: <chengminglin@mxic.com.tw>, <leoyu@mxic.com.tw>,
"AlvinZhou" <alvinzhou@mxic.com.tw>,
"JaimeLiao" <jaimeliao@mxic.com.tw>,
"Bough Chen" <haibo.chen@nxp.com>
Subject: Re: [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash
Date: Mon, 23 Sep 2024 09:18:01 +0200 [thread overview]
Message-ID: <D4DHAZ1MIJV2.1G810GI4K5DVV@kernel.org> (raw)
In-Reply-To: <97134efb-398d-4c21-a915-87a5b4f1b29a@linaro.org>
Hi,
> > --- a/drivers/mtd/spi-nor/macronix.c
> > +++ b/drivers/mtd/spi-nor/macronix.c
> > @@ -200,7 +200,9 @@ static const struct flash_info macronix_nor_parts[] = {
> > .name = "mx25l3255e",
> > .size = SZ_4M,
> > .no_sfdp_flags = SECT_4K,
> > - }
> > + },
> > + /* Need the manufacturer fixups, Keep this last */
> > + { .id = SNOR_ID(0xc2) }
> > };
> >
>
> Could you please elaborate why you need just the manufacturer id here? I
> would have expected to see a specific flash entry instead.
I can't find the thread anymore as this is going on for forever, but
that was my suggestion. That's a catch all to have the manufacturer
fixup applied for any macronix flashes instead of having to list
each flash id here.
-michael
next prev parent reply other threads:[~2024-09-23 7:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 3:46 [PATCH v9 0/6] Add octal DTR support for Macronix flash AlvinZhou
2024-07-18 3:46 ` [PATCH v9 1/6] mtd: spi-nor: add Octal " AlvinZhou
2024-07-18 3:46 ` [PATCH v9 2/6] spi: spi-mem: Allow specifying the byte order in Octal DTR mode AlvinZhou
2024-09-24 11:37 ` Mark Brown
2024-07-18 3:46 ` [PATCH v9 3/6] mtd: spi-nor: core: " AlvinZhou
2024-07-18 3:46 ` [PATCH v9 4/6] mtd: spi-nor: sfdp: Get the 8D-8D-8D byte order from BFPT AlvinZhou
2024-07-18 3:46 ` [PATCH v9 5/6] spi: mxic: Add support for swapping byte AlvinZhou
2024-09-24 11:38 ` Mark Brown
2024-09-24 14:29 ` Tudor Ambarus
2024-09-24 14:52 ` Mark Brown
2024-09-25 6:22 ` Tudor Ambarus
2024-07-18 3:46 ` [PATCH v9 6/6] mtd: spi-nor: add support for Macronix Octal flash AlvinZhou
2024-09-23 6:53 ` Tudor Ambarus
2024-09-23 7:18 ` Michael Walle [this message]
2024-09-24 3:25 ` Alvin Zhou
2024-09-24 6:26 ` Tudor Ambarus
2024-09-24 6:36 ` Tudor Ambarus
2024-09-24 7:17 ` Tudor Ambarus
2024-09-25 9:57 ` Miquel Raynal
2024-09-26 3:06 ` Alvin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4DHAZ1MIJV2.1G810GI4K5DVV@kernel.org \
--to=mwalle@kernel.org \
--cc=alvinzhou.tw@gmail.com \
--cc=alvinzhou@mxic.com.tw \
--cc=broonie@kernel.org \
--cc=chengminglin@mxic.com.tw \
--cc=haibo.chen@nxp.com \
--cc=jaimeliao@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).