From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Applied "spi: dw: introduce spi_shutdown_chip()" to the spi tree
Date: Mon, 19 Oct 2015 20:43:27 +0100 [thread overview]
Message-ID: <E1ZoGL9-0002KK-0Q@debutante> (raw)
In-Reply-To: <1444853545-59868-9-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
The patch
spi: dw: introduce spi_shutdown_chip()
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 1cc3f141f0cb5a822cdef30fb1d92ae6f4176bfa Mon Sep 17 00:00:00 2001
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Date: Wed, 14 Oct 2015 23:12:23 +0300
Subject: [PATCH] spi: dw: introduce spi_shutdown_chip()
This helper disables SPI controller and sets clock to 0.
Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/spi/spi-dw.c | 13 ++++++-------
drivers/spi/spi-dw.h | 6 ++++++
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c
index c8e7715097e7..a730c353d3bf 100644
--- a/drivers/spi/spi-dw.c
+++ b/drivers/spi/spi-dw.c
@@ -546,22 +546,21 @@ void dw_spi_remove_host(struct dw_spi *dws)
if (dws->dma_ops && dws->dma_ops->dma_exit)
dws->dma_ops->dma_exit(dws);
- spi_enable_chip(dws, 0);
- /* Disable clk */
- spi_set_clk(dws, 0);
+
+ spi_shutdown_chip(dws);
}
EXPORT_SYMBOL_GPL(dw_spi_remove_host);
int dw_spi_suspend_host(struct dw_spi *dws)
{
- int ret = 0;
+ int ret;
ret = spi_master_suspend(dws->master);
if (ret)
return ret;
- spi_enable_chip(dws, 0);
- spi_set_clk(dws, 0);
- return ret;
+
+ spi_shutdown_chip(dws);
+ return 0;
}
EXPORT_SYMBOL_GPL(dw_spi_suspend_host);
diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
index b75ed327d5a2..35589a270468 100644
--- a/drivers/spi/spi-dw.h
+++ b/drivers/spi/spi-dw.h
@@ -225,6 +225,12 @@ static inline void spi_reset_chip(struct dw_spi *dws)
spi_enable_chip(dws, 1);
}
+static inline void spi_shutdown_chip(struct dw_spi *dws)
+{
+ spi_enable_chip(dws, 0);
+ spi_set_clk(dws, 0);
+}
+
/*
* Each SPI slave device to work with dw_api controller should
* has such a structure claiming its working mode (poll or PIO/DMA),
--
2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-19 19:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 20:12 [PATCH v1 00/10] spi: dw: bug fix and clean up series Andy Shevchenko
[not found] ` <1444853545-59868-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-14 20:12 ` [PATCH v1 01/10] spi: dw: explicitly free IRQ handler in dw_spi_remove_host() Andy Shevchenko
[not found] ` <1444853545-59868-2-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:29 ` Mark Brown
2015-10-14 20:12 ` [PATCH v1 02/10] spi: dw: use plain struct device * at earlier ->probe() Andy Shevchenko
[not found] ` <1444853545-59868-3-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw: use plain struct device * at earlier ->probe()" to the spi tree Mark Brown
2015-10-14 20:12 ` [PATCH v1 03/10] spi: dw: remove unneeded cr0 member of struct chip_data Andy Shevchenko
[not found] ` <1444853545-59868-4-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw: remove unneeded cr0 member of struct chip_data" to the spi tree Mark Brown
2015-10-14 20:12 ` [PATCH v1 04/10] spi: dw: remove a NULL check when call ->remove() Andy Shevchenko
[not found] ` <1444853545-59868-5-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:32 ` Mark Brown
2015-10-14 20:12 ` [PATCH v1 05/10] spi: dw: remove bits_per_word member of struct chip_data Andy Shevchenko
[not found] ` <1444853545-59868-6-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw: remove bits_per_word member of struct chip_data" to the spi tree Mark Brown
2015-10-14 20:12 ` [PATCH v1 06/10] spi: dw: eliminate speed variable in ->transfer_one() Andy Shevchenko
[not found] ` <1444853545-59868-7-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw: eliminate speed variable in ->transfer_one()" to the spi tree Mark Brown
2015-10-14 20:12 ` [PATCH v1 07/10] spi: dw: eliminate unused threshold variables Andy Shevchenko
[not found] ` <1444853545-59868-8-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw: eliminate unused threshold variables" to the spi tree Mark Brown
2015-10-14 20:12 ` [PATCH v1 08/10] spi: dw: introduce spi_shutdown_chip() Andy Shevchenko
[not found] ` <1444853545-59868-9-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Mark Brown [this message]
2015-10-14 20:12 ` [PATCH v1 09/10] spi: dw-pci: remove unused pdev member from struct dw_spi_pci Andy Shevchenko
[not found] ` <1444853545-59868-10-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw-pci: remove unused pdev member from struct dw_spi_pci" to the spi tree Mark Brown
2015-10-14 20:12 ` [PATCH v1 10/10] spi: dw-mmio: convert to unified device property API Andy Shevchenko
[not found] ` <1444853545-59868-11-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-10-19 19:43 ` Applied "spi: dw-mmio: convert to unified device property API" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1ZoGL9-0002KK-0Q@debutante \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox