From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Applied "spi: lm70llp: use dev_warn" to the spi tree
Date: Mon, 07 Dec 2015 20:09:31 +0000 [thread overview]
Message-ID: <E1a626F-0004Vu-Rg@debutante> (raw)
In-Reply-To: <1449485255-1103-7-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
The patch
spi: lm70llp: use dev_warn
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 46c52c28deb38df19b1284468792fb59e6a6c27b Mon Sep 17 00:00:00 2001
From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Mon, 7 Dec 2015 16:17:34 +0530
Subject: [PATCH] spi: lm70llp: use dev_warn
As we have a struct device available it is better to use dev_warn()
instead of printk.
Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/spi/spi-lm70llp.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index ef829081abd7..cb2284475385 100644
--- a/drivers/spi/spi-lm70llp.c
+++ b/drivers/spi/spi-lm70llp.c
@@ -249,9 +249,8 @@ static void spi_lm70llp_attach(struct parport *p)
*/
status = spi_bitbang_start(&pp->bitbang);
if (status < 0) {
- printk(KERN_WARNING
- "%s: spi_bitbang_start failed with status %d\n",
- DRVNAME, status);
+ dev_warn(&pd->dev, "spi_bitbang_start failed with status %d\n",
+ status);
goto out_off_and_release;
}
@@ -278,7 +277,7 @@ static void spi_lm70llp_attach(struct parport *p)
dev_dbg(&pp->spidev_lm70->dev, "spidev_lm70 at %s\n",
dev_name(&pp->spidev_lm70->dev));
else {
- printk(KERN_WARNING "%s: spi_new_device failed\n", DRVNAME);
+ dev_warn(&pd->dev, "spi_new_device failed\n");
status = -ENODEV;
goto out_bitbang_stop;
}
--
2.6.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-07 20:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 10:47 [PATCH v2 1/8] spi: lm70llp: remove multiple blank lines Sudip Mukherjee
[not found] ` <1449485255-1103-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07 10:47 ` [PATCH v2 2/8] spi: lm70llp: add blank line after declaration Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 3/8] spi: lm70llp: remove cast to void Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 8/8] spi: lm70llp: remove printk Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 4/8] spi: lm70llp: correct alignment Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 5/8] spi: lm70llp: remove space Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 6/8] spi: lm70llp: use new parport device model Sudip Mukherjee
2015-12-07 10:47 ` [PATCH v2 7/8] spi: lm70llp: use dev_warn Sudip Mukherjee
[not found] ` <1449485255-1103-7-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-12-07 20:09 ` Mark Brown [this message]
2015-12-07 20:07 ` [PATCH v2 1/8] spi: lm70llp: remove multiple blank lines Mark Brown
2015-12-08 4:33 ` Sudip Mukherjee
2015-12-08 12:49 ` Mark Brown
[not found] ` <20151208124956.GR5727-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-08 14:30 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1a626F-0004Vu-Rg@debutante \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox