* [PATCH] spi: orion: remove redundant assignment of status to zero
@ 2017-11-02 12:16 Colin King
2017-11-02 13:21 ` Applied "spi: orion: remove redundant assignment of status to zero" to the spi tree Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-11-02 12:16 UTC (permalink / raw)
To: Mark Brown, linux-spi; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of status to zero is never read, status is either
updated in the next iteration of the of the loop or several
lines after the end of the loop. Remove it, cleans up clang warning:
drivers/spi/spi-orion.c:674:4: warning: Value stored to 'status'
is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/spi/spi-orion.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index 4b6dd73b80da..8974bb340b3a 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -671,7 +671,6 @@ static int orion_spi_probe(struct platform_device *pdev)
dev_err(&pdev->dev,
"%pOF has no valid 'reg' property (%d)\n",
np, status);
- status = 0;
continue;
}
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Applied "spi: orion: remove redundant assignment of status to zero" to the spi tree
2017-11-02 12:16 [PATCH] spi: orion: remove redundant assignment of status to zero Colin King
@ 2017-11-02 13:21 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2017-11-02 13:21 UTC (permalink / raw)
To: Colin Ian King
Cc: Mark Brown, Mark Brown, linux-spi, kernel-janitors, linux-kernel,
linux-spi
The patch
spi: orion: remove redundant assignment of status to zero
has been applied to the spi tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From f747c3104efd1e21528d368910afd978fbcd6a78 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 2 Nov 2017 12:16:25 +0000
Subject: [PATCH] spi: orion: remove redundant assignment of status to zero
The assignment of status to zero is never read, status is either
updated in the next iteration of the of the loop or several
lines after the end of the loop. Remove it, cleans up clang warning:
drivers/spi/spi-orion.c:674:4: warning: Value stored to 'status'
is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-orion.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index 4b6dd73b80da..8974bb340b3a 100644
--- a/drivers/spi/spi-orion.c
+++ b/drivers/spi/spi-orion.c
@@ -671,7 +671,6 @@ static int orion_spi_probe(struct platform_device *pdev)
dev_err(&pdev->dev,
"%pOF has no valid 'reg' property (%d)\n",
np, status);
- status = 0;
continue;
}
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-02 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-02 12:16 [PATCH] spi: orion: remove redundant assignment of status to zero Colin King
2017-11-02 13:21 ` Applied "spi: orion: remove redundant assignment of status to zero" to the spi tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).