From: Thierry Reding <thierry.reding@gmail.com>
To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc: robh+dt@kernel.org, broonie@kernel.org, peterhuewe@gmx.de,
jgg@ziepe.ca, jarkko@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-spi@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com,
skomatineni@nvidia.com, ldewangan@nvidia.com
Subject: Re: [Patch V6 2/3] tpm_tis-spi: Support hardware wait polling
Date: Wed, 1 Mar 2023 14:37:45 +0100 [thread overview]
Message-ID: <Y/9VKV6ddpWlmU9f@orome> (raw)
In-Reply-To: <20230227172108.8206-3-kyarlagadda@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]
On Mon, Feb 27, 2023 at 10:51:07PM +0530, Krishna Yarlagadda wrote:
[...]
> diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
[...]
> @@ -140,6 +206,28 @@ int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
> return ret;
> }
>
> +int tpm_tis_spi_transfer(struct tpm_tis_data *data, u32 addr, u16 len,
> + u8 *in, const u8 *out)
> +{
> + struct tpm_tis_spi_phy *phy = to_tpm_tis_spi_phy(data);
> + struct spi_controller *ctlr = phy->spi_device->controller;
> +
> + /*
> + * TPM flow control over SPI requires full duplex support.
> + * Send entire message to a half duplex controller to handle
> + * wait polling in controller.
> + * Set TPM HW flow control flag..
> + */
> + if (ctlr->flags & SPI_CONTROLLER_HALF_DUPLEX) {
> + phy->spi_device->mode |= SPI_TPM_HW_FLOW;
Can this be pushed up to tpm_tis_spi_probe()? The SPI controller flags
are fixed, so this isn't going to change at runtime, is it?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-01 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:21 [Patch V6 0/3] Tegra TPM driver with HW flow control Krishna Yarlagadda
2023-02-27 17:21 ` [Patch V6 1/3] spi: Add TPM HW flow flag Krishna Yarlagadda
2023-03-01 13:34 ` Thierry Reding
2023-03-01 15:27 ` Krishna Yarlagadda
2023-02-27 17:21 ` [Patch V6 2/3] tpm_tis-spi: Support hardware wait polling Krishna Yarlagadda
2023-03-01 13:37 ` Thierry Reding [this message]
2023-02-27 17:21 ` [Patch V6 3/3] spi: tegra210-quad: Enable TPM " Krishna Yarlagadda
2023-03-01 13:39 ` Thierry Reding
2023-03-01 13:41 ` Thierry Reding
2023-03-01 13:51 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9VKV6ddpWlmU9f@orome \
--to=thierry.reding@gmail.com \
--cc=broonie@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).