From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Michael Walle <michael@walle.cc>
Cc: mauro.lima@eclypsium.com, broonie@kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/1] spi: intel: Remove DANGEROUS tag from pci driver
Date: Tue, 7 Feb 2023 16:03:20 +0200 [thread overview]
Message-ID: <Y+JaKF4FZQKqeGs7@black.fi.intel.com> (raw)
In-Reply-To: <20230207135254.2465816-1-michael@walle.cc>
Hi,
On Tue, Feb 07, 2023 at 02:52:54PM +0100, Michael Walle wrote:
> > Modern CPUs exposes this controller as PCI device that only uses
> > hardware sequencing capabilities which is safer than software
> > sequencing.
> > Leave the platform driver as *DANGEROUS* and update help text since
> > most of these controllers are using software sequencing.
>
> Out of curiosity, what is hardware sequencing? Maybe this should
> be explained a bit more in the Kconfig help text. Looks like the
> dangerous was there because you can update the bios and that
> could eventually lead to a bricked mainboard. So hardware
> sequencing helps there? how?
Hardware sequencing means the controller exposes just a bunch of "high
level" operations to the software. Such as read, write, erase and so on
but does not allow running the actual "low level" SPI-NOR opcodes.
Software sequencing on the other hand allows running pretty much any
opcode and this is what caused problems for certain Lenovo laptops few
years back that then resulted adding DANGEROUS to the Kconfig.
Typically the flash is locked by the BIOS so ordinary users cannot
really overwrite it, even by accident.
next prev parent reply other threads:[~2023-02-07 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 18:31 [PATCH 0/1] spi: intel: Remove DANGEROUS tag from pci driver Mauro Lima
2023-02-06 18:31 ` [PATCH 1/1] " Mauro Lima
2023-02-07 5:56 ` Mika Westerberg
2023-02-07 13:52 ` Michael Walle
2023-02-07 14:03 ` Mika Westerberg [this message]
2023-02-07 14:11 ` Michael Walle
2023-02-07 14:45 ` Mika Westerberg
2023-02-07 20:44 ` Mauro Lima
2023-02-07 11:51 ` [PATCH 0/1] " Mark Brown
2023-02-07 15:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+JaKF4FZQKqeGs7@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mauro.lima@eclypsium.com \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).