From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Mark Brown <broonie@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 0/6] memory: renesas-rpc-if: Rebind fixes and misc cleanups
Date: Mon, 5 Dec 2022 09:56:36 +0100 [thread overview]
Message-ID: <Y42yRFSai6XKnLiC@ninjato> (raw)
In-Reply-To: <cover.1669213027.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Wed, Nov 23, 2022 at 03:41:16PM +0100, Geert Uytterhoeven wrote:
> Hi all,
>
> The Renesas RPC-IF provides either HyperFlash or SPI host access.
> To handle this, three drivers are used:
> 1. The RPC-IF core diver,
> 2. An HyperFlash child driver,
> 3. An SPI child driver.
>
> Currently this driver collection suffers from a sub-optimal division of
> roles and reponsibilities, leading to (un)bind issues: after manually
> unbinding the child driver, rebinding the child driver fails with
> -EBUSY.
>
> This patch series aims to fix this, by splitting off private data and
> making the RPC-IF core driver responsible for resource acquisition.
> After that, a few customary cleanups are provided.
>
> This has been tested on the Salvator-X(S) and Ebisu-4D (HyperFlash) and
> White-Hawk (QSPI FLASH) development boards.
Sadly, I don't have the bandwidth to do a full review. But from a
glimpse, it all looks good. And from a high level PoV, this all makes a
lot of sense. So:
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-12-05 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 14:41 [PATCH v2 0/6] memory: renesas-rpc-if: Rebind fixes and misc cleanups Geert Uytterhoeven
2022-11-23 14:41 ` [PATCH v2 1/6] memory: renesas-rpc-if: Split-off private data from struct rpcif Geert Uytterhoeven
2022-11-23 14:41 ` [PATCH v2 2/6] memory: renesas-rpc-if: Move resource acquisition to .probe() Geert Uytterhoeven
2022-11-23 14:41 ` [PATCH v2 3/6] memory: renesas-rpc-if: Always use dev in rpcif_probe() Geert Uytterhoeven
2022-11-23 14:41 ` [PATCH v2 4/6] memory: renesas-rpc-if: Improve Runtime PM handling Geert Uytterhoeven
2022-11-23 14:41 ` [PATCH v2 5/6] memory: renesas-rpc-if: Pass device instead of rpcif to rpcif_*() Geert Uytterhoeven
2022-11-23 14:43 ` Mark Brown
2022-11-23 14:41 ` [PATCH v2 6/6] memory: renesas-rpc-if: Remove Runtime PM wrappers Geert Uytterhoeven
2022-11-27 21:31 ` [PATCH v2 0/6] memory: renesas-rpc-if: Rebind fixes and misc cleanups Krzysztof Kozlowski
2022-11-27 21:34 ` Krzysztof Kozlowski
2022-11-28 7:37 ` Geert Uytterhoeven
2022-12-05 8:56 ` Wolfram Sang [this message]
2022-12-27 8:59 ` Krzysztof Kozlowski
2022-12-27 9:06 ` Krzysztof Kozlowski
2022-12-27 9:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y42yRFSai6XKnLiC@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=richard@nod.at \
--cc=s.shtylyov@omp.ru \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).