From: Vinod Koul <vkoul@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
akashast@codeaurora.org, swboyd@chromium.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: spi-geni-qcom: Remove confusing comment about setting the watermark
Date: Wed, 14 Jul 2021 15:44:36 +0530 [thread overview]
Message-ID: <YO65DHLzjIAV4P/D@matsya> (raw)
In-Reply-To: <20210712085010.1.Ie3bb9f9d30d6475bb75251d32635194c1c72b9ee@changeid>
On 12-07-21, 08:50, Douglas Anderson wrote:
> The comment in setup_fifo_xfer() about setting the watermark wasn't
> quite proper grammar and also stopped making sense around commit
> 6d66507d9b55 ("spi: spi-geni-qcom: Don't wait to start 1st transfer if
> transmitting"). After that commit we actually start the transfer
> _before_ the watermark interrupt comes.
>
> I don't think the comment really has any value anymore. We've already
> got a comment when we grab the spinlock saying that our interrupt can
> come any time as a result of the things in the locked section. Let's
> just remove it.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2021-07-14 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:50 [PATCH] spi: spi-geni-qcom: Remove confusing comment about setting the watermark Douglas Anderson
2021-07-14 10:14 ` Vinod Koul [this message]
2021-07-14 15:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO65DHLzjIAV4P/D@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).