From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andreas Schwab <schwab@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: broonie@kernel.org, Marco Felsch <m.felsch@pengutronix.de>,
linux-spi@vger.kernel.org, kernel@pengutronix.de
Subject: Re: REGRESSION: "spi: add of_device_uevent_modalias support" and following "fix" breaks Macchiatobin
Date: Mon, 20 Sep 2021 20:49:21 +0100 [thread overview]
Message-ID: <YUjlwaRdmFMZHJYO@shell.armlinux.org.uk> (raw)
In-Reply-To: <871r5j6nlw.fsf@igel.home>
On Mon, Sep 20, 2021 at 09:41:47PM +0200, Andreas Schwab wrote:
> On Sep 20 2021, Russell King (Oracle) wrote:
>
> > Therefore, this change breaks module autoloading.
>
> Reverting this change breaks module autoloading.
No.
Module autoloading worked before. Then someone probably noticed a
problem, and thought they'd fix it by changing how the module alias
strings SPI provides are produced. In fixing it, they broke existing
setups that have worked for years.
If you think it's acceptable to break existing setups to fix a bug
you need to be reminded of Linus' rant:
https://lkml.org/lkml/2018/8/3/621
" Bugs happen. That's a fact of life. Arguing that "we had to break
something because we were fixing a bug" is completely insane. We fix
tens of bugs every single day, thinking that "fixing a bug" means
that we can break something is simply NOT TRUE."
It seems that is exactly what has happened here: a change was
introduced to fix an apparently module autoloading bug that has
caused _another_ module autoloading bug that wasn't originally
there.
That is not fixing a bug at all.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-09-21 1:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 10:20 REGRESSION: "spi: add of_device_uevent_modalias support" and following "fix" breaks Macchiatobin Russell King (Oracle)
2021-09-20 18:33 ` Mark Brown
2021-09-20 19:37 ` Russell King (Oracle)
2021-09-20 21:25 ` Mark Brown
2021-09-21 10:55 ` Russell King (Oracle)
2021-09-20 19:41 ` Andreas Schwab
2021-09-20 19:49 ` Russell King (Oracle) [this message]
2021-09-20 20:52 ` Mark Brown
2021-09-20 21:56 ` Andreas Schwab
2021-09-20 22:25 ` Linus Torvalds
2021-10-04 14:00 ` Andreas Schwab
2021-10-04 14:30 ` Mark Brown
2021-10-04 15:23 ` Andreas Schwab
2021-09-20 22:43 ` Russell King (Oracle)
2021-09-21 7:34 ` Andreas Schwab
2021-09-21 12:22 ` Mark Brown
2021-09-21 13:02 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUjlwaRdmFMZHJYO@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-spi@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=schwab@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).