From: Vinod Koul <vkoul@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan()
Date: Wed, 10 Nov 2021 17:37:40 +0530 [thread overview]
Message-ID: <YYu2DD3tFyxMB5Gz@matsya> (raw)
In-Reply-To: <20211110073935.GA5176@kili>
On 10-11-21, 10:39, Dan Carpenter wrote:
> This code has several issues:
> 1) It passes IS_ERR() to dev_err_probe() instead of PTR_ERR().
> 2) It always prints an error message, even when it succeeds.
> 3) The "if (ret < 0) {" conditions are never true.
> 4) If requesting "mas->tx" fails then it sets "mas->rx" to NULL but the
> intention was to set "mas->tx" to NULL.
Acked-By: Vinod Koul <vkoul@kernel.org>
--
~Vinod
next prev parent reply other threads:[~2021-11-10 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 7:39 [PATCH] spi: spi-geni-qcom: fix error handling in spi_geni_grab_gpi_chan() Dan Carpenter
2021-11-10 12:07 ` Vinod Koul [this message]
2021-11-12 21:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYu2DD3tFyxMB5Gz@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).