From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>,
linux-integrity@vger.kernel.org, Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, linux-spi@vger.kernel.org
Subject: Re: [PATCH v3] tpm: st33zp24: Make st33zp24_remove() a void function
Date: Fri, 7 Jan 2022 13:44:58 +0200 [thread overview]
Message-ID: <YdgnuvGIq1DcLlJT@iki.fi> (raw)
In-Reply-To: <20220104231103.227924-1-u.kleine-koenig@pengutronix.de>
On Wed, Jan 05, 2022 at 12:11:03AM +0100, Uwe Kleine-König wrote:
> Up to now st33zp24_remove() returns zero unconditionally. Make it return
> no value instead which makes it easier to see in the callers that there is
> no error to handle.
>
> Also the return value of i2c and spi remove callbacks is ignored anyway.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
This patch does not improve functinality in any possible way, and neither
does it fix any bug.
/Jarkko
next prev parent reply other threads:[~2022-01-07 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 23:11 [PATCH v3] tpm: st33zp24: Make st33zp24_remove() a void function Uwe Kleine-König
2022-01-07 11:44 ` Jarkko Sakkinen [this message]
2022-01-07 21:42 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdgnuvGIq1DcLlJT@iki.fi \
--to=jarkko@kernel.org \
--cc=broonie@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kernel@pengutronix.de \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).