From: Mark Brown <broonie@kernel.org>
To: Yun Zhou <yun.zhou@windriver.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xue, Ying" <Ying.Xue@windriver.com>
Subject: Re: 回复: [PATCH] spi: disable chipselect after complete transfer
Date: Wed, 16 Feb 2022 16:23:12 +0000 [thread overview]
Message-ID: <Yg0k8BH0itmczUDy@sirena.org.uk> (raw)
In-Reply-To: <111c2102-5782-2740-65b0-47b0e5194ce9@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]
On Wed, Feb 16, 2022 at 06:41:21PM +0800, Yun Zhou wrote:
> On 2/14/22 10:36 PM, Mark Brown wrote:
> > ever or that it'd be done this way if it were new but that doesn't mean
> > we can just randomly change the interface and potentially disrupt users.
> > Whatever else is going on the current behaviour is intentional.
> Although the logic dealing with cs_change in spi_transfer_one_message() has
> existed a long time and nobody reports issue on it, that doesn't mean it is
> correct. I think the main reason is, cs_change is only used to change
Please read and engage with what what I said above about not disrupting
existing users by just randomly changing this, silently changing how the
parameter operates will break any users that rely on the functionality
which is not going to help anyone and to the extent there is an issue
here it is only those users who would be affected in the first place.
This is not a productive discussion, please stop unless you have
concrete proposals that are considerate of existing users.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-02-16 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SN6PR11MB3008AF5619B0B026836FD7429F2F9@SN6PR11MB3008.namprd11.prod.outlook.com>
2022-02-10 15:57 ` 回复: [PATCH] spi: disable chipselect after complete transfer Mark Brown
2022-02-10 17:01 ` Yun Zhou
2022-02-10 17:14 ` Mark Brown
2022-02-14 12:35 ` Yun Zhou
2022-02-14 12:45 ` Mark Brown
[not found] ` <8fd9c3ef-df64-b8ad-de6e-ef86806d53b5@windriver.com>
2022-02-14 14:36 ` Mark Brown
2022-02-16 10:41 ` Yun Zhou
2022-02-16 16:23 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg0k8BH0itmczUDy@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Ying.Xue@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox