From: Mark Brown <broonie@kernel.org>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Philipp Zabel <p.zabel@pengutronix.de>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>
Subject: Re: [PATCH] spi: dw: assert reset before deasserting reset
Date: Fri, 11 Mar 2022 16:06:09 +0000 [thread overview]
Message-ID: <YitzcXjKVLRPmQuF@sirena.org.uk> (raw)
In-Reply-To: <Yitv+tKTH2RpTV2K@x1-carbon>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Fri, Mar 11, 2022 at 03:51:23PM +0000, Niklas Cassel wrote:
> I think it is a good to start off with all registers in their
> default reset values.
> Arguably, I think it looks wrong to see a reset_control_deassert()
> without any previous reset_control_assert().
I do tend to agree that if we've got the ability to do a reset it's good
practice to use it to get the hardware into a known state, it just
guards against the possibility that there's some system or configuration
where things are left in a surprising state which ends up causing
problems. Unless the reset is going to take a long time there should be
no real downside even if the upside is marginal.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-11 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 11:17 [PATCH] spi: dw: assert reset before deasserting reset Niklas Cassel
2022-03-11 14:25 ` Serge Semin
2022-03-11 15:51 ` Niklas Cassel
2022-03-11 16:06 ` Mark Brown [this message]
2022-03-11 17:05 ` Serge Semin
2022-03-16 14:11 ` Niklas Cassel
2022-03-17 10:17 ` Philipp Zabel
2022-03-22 10:32 ` Niklas Cassel
2022-03-22 11:08 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YitzcXjKVLRPmQuF@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Niklas.Cassel@wdc.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=fancer.lancer@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).