From: Mark Brown <broonie@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Zhou Yanjie <zhouyanjie@wanyeetech.com>,
robh+dt@kernel.org, krzk+dt@kernel.org,
linux-spi@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
contact@artur-rojek.eu, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
reimu@sudomaker.com
Subject: Re: [PATCH 1/3] SPI: Ingenic: Add support for use GPIO as chip select line.
Date: Tue, 19 Apr 2022 18:00:41 +0100 [thread overview]
Message-ID: <Yl7quUXmEEPHfTfC@sirena.org.uk> (raw)
In-Reply-To: <A5YFAR.5U5RNX82OXJY1@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Sat, Apr 16, 2022 at 05:36:46PM +0100, Paul Cercueil wrote:
> Le sam., avril 16 2022 at 19:55:13 +0800, Zhou Yanjie
> > On 2022/4/15 下午11:00, Paul Cercueil wrote:
> > > > - ctlr->num_chipselect = 2;
> > > > + ctlr->use_gpio_descriptors = true;
> > > I wonder if this should be set conditionally instead. Maybe set it
> > > to \x7f"true" if the "num-cs" property exists?
> > I'm not too sure, but it seems some other drivers like "spi-sun6i.c",
> > "spi-stm32.c", "spi-s3c64xx.c", "spi-pic32.c", etc. set it
> > unconditionally.
> Ok, maybe Mark can enlighten us here.
use_gpio_descriptions is just selecting which version of the GPIO APIs
we should use if we're handling GPIOs rather than if we should handle
them. We've got one last driver using the numerical GPIO APIs, once
that one is converted we should just be able to drop the flag since
everything will be using descriptors.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-19 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 14:22 [PATCH 0/3] Improve SPI support for Ingenic SoCs 周琰杰 (Zhou Yanjie)
2022-04-15 14:22 ` [PATCH 1/3] SPI: Ingenic: Add support for use GPIO as chip select line 周琰杰 (Zhou Yanjie)
2022-04-15 15:00 ` Paul Cercueil
2022-04-16 11:55 ` Zhou Yanjie
2022-04-16 16:36 ` Paul Cercueil
2022-04-19 17:00 ` Mark Brown [this message]
2022-04-19 17:10 ` Paul Cercueil
2022-04-19 17:28 ` Zhou Yanjie
2022-04-19 17:13 ` Paul Cercueil
2022-04-19 17:29 ` Zhou Yanjie
2022-04-15 14:22 ` [PATCH 2/3] dt-bindings: SPI: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2022-04-15 15:03 ` Paul Cercueil
2022-04-18 12:26 ` Krzysztof Kozlowski
2022-04-15 14:22 ` [PATCH 3/3] SPI: Ingenic: Add support " 周琰杰 (Zhou Yanjie)
2022-04-15 15:04 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl7quUXmEEPHfTfC@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aric.pzqi@ingenic.com \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=reimu@sudomaker.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).