From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F5D2C433F5 for ; Wed, 20 Apr 2022 13:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357489AbiDTNHS (ORCPT ); Wed, 20 Apr 2022 09:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352604AbiDTNHR (ORCPT ); Wed, 20 Apr 2022 09:07:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1A2415A13; Wed, 20 Apr 2022 06:04:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82E8BB81F0D; Wed, 20 Apr 2022 13:04:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF021C385A1; Wed, 20 Apr 2022 13:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650459869; bh=xWASg+ifbn2uVha8nfvnCveQNEqoOf0q74ePOsRwNE8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HGh9s/mBegJmMEJbl/CbemQQcdqWqduGRlNe8NolJJusCEepEAGhP4EIUYzP/EgAC GmuHVNPpK+iY7/laRC1PcOFQ8cpjNFtqmpzHDe3CluEkHLai1DAEMoDTuFedKXwv4n 02rUGQNbuCh5T+gfrxsgqLHPaWEkhxiINgl1ZtLap/qWGm68arBvMRzcquZsz27pN2 DcLj2pe6sdgfrFoRCEz59tymcpcqYvFc+3wd7pHxzlVmvsDX1rT78GZyPxJ+vATnrp ShoPqO+kiXzVLoocs7Sam6hHnvymZNhWjD4zIoSYhPvjV7aSln8ZYv562U88W/ebiG DJeBzBek6avpQ== Date: Wed, 20 Apr 2022 14:04:24 +0100 From: Mark Brown To: Pratyush Yadav Cc: Tudor Ambarus , Michael Walle , Miquel Raynal , Takahiro Kuwano , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] spi: spi-mem: check if data buffers are on stack Message-ID: References: <20220420102022.3310970-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aiCEfvR0m8oWhfqc" Content-Disposition: inline In-Reply-To: <20220420102022.3310970-1-p.yadav@ti.com> X-Cookie: Will it improve my CASH FLOW? Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --aiCEfvR0m8oWhfqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 20, 2022 at 03:50:22PM +0530, Pratyush Yadav wrote: > The buffers passed in the data phase must be DMA-able. Programmers often > don't realise this requirement and pass in buffers that reside on the > stack. This can be hard to spot when reviewing code. Reject ops if their > data buffer is on the stack to avoid this. >=20 > Signed-off-by: Pratyush Yadav > Acked-by: Mark Brown > --- >=20 > Changes in v2: > - Include task_stack.h. It might not get included indirectly on some > platforms and can cause build failures. > - Add a WARN_ON_ONCE() for debuggability. > - Add Mark's Ack. Since this is now an isolated patch does that mean whatever meant that I acked rather than applying this patch has gone in and I can now apply it directly? --aiCEfvR0m8oWhfqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJgBNcACgkQJNaLcl1U h9AVUAf/Thouk4ikZ3+sC6mFcLBnUb0rdoYUyN/9GyPZwVx0Bu6Bj3KLvfMdR2HI +tn5BCsE8epyRgcCG0tiCfD0Mmv/CV68z8GPMnDdQGtvnMVRSKy9VsBhAuzvy68x e9lQdmScs6JUJezqCJIGHW+ElYAGR8lymrCHbfFsI1/0+WTj6LueWOAR4m4e3F9P KNkk50p8ulvfQBu++34jUgHOOJF1HktB5DfqpY4UabmP+iUMvm10Cj6WytRZoztG CcpugWP1yiqoiLjEQQal8tYvLMIWMmSlGPYl2nylVGxGCzf07TZNtk17R1CIGQjN zMcrx5SUsSY7THkrvpdybENmrvUVow== =CnG+ -----END PGP SIGNATURE----- --aiCEfvR0m8oWhfqc--