From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects
Date: Wed, 4 May 2022 10:37:02 -0500 [thread overview]
Message-ID: <YnKdnv69vueSURiU@robh.at.kernel.org> (raw)
In-Reply-To: <20220504125119.190526-1-krzysztof.kozlowski@linaro.org>
On Wed, May 04, 2022 at 02:51:19PM +0200, Krzysztof Kozlowski wrote:
> Recent Qualcomm Geni SPI nodes, e.g. on SM8450, come with three
> interconnects. This fixes dtbs_check warnings like:
>
> sm8450-qrd.dtb: geniqup@8c0000: spi@880000:interconnect-names: ['qup-core', 'qup-config'] is too short
I'm confused. A length of 2 was already allowed before this change.
>
> Fixes: 5bdcae1fe1c5 ("spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Fix for a commit in MSM/Bjorn's tree.
> ---
> .../devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index e2c7b934c50d..47e1b3ee8b1b 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -45,12 +45,15 @@ properties:
> - const: rx
>
> interconnects:
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
>
> interconnect-names:
> + minItems: 2
> items:
> - const: qup-core
> - const: qup-config
> + - const: qup-memory
>
> interrupts:
> maxItems: 1
> --
> 2.32.0
>
>
next prev parent reply other threads:[~2022-05-04 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 12:51 [PATCH] spi: dt-bindings: qcom,spi-geni-qcom: allow three interconnects Krzysztof Kozlowski
2022-05-04 15:01 ` Mark Brown
2022-05-04 15:14 ` Krzysztof Kozlowski
2022-05-04 15:20 ` Mark Brown
2022-05-05 9:00 ` Krzysztof Kozlowski
2022-05-05 15:26 ` Mark Brown
2022-05-04 15:37 ` Rob Herring [this message]
2022-05-05 6:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnKdnv69vueSURiU@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).