From: Mark Brown <broonie@kernel.org>
To: David Jander <david@protonic.nl>
Cc: Andrew Lunn <andrew@lunn.ch>,
linux-spi@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH] drivers: spi: spi.c: Convert statistics to per-cpu u64_stats_t
Date: Tue, 24 May 2022 12:46:10 +0100 [thread overview]
Message-ID: <YozFgptOEr09+NMi@sirena.org.uk> (raw)
In-Reply-To: <20220524082506.0aa4fde6@erd992>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On Tue, May 24, 2022 at 08:25:06AM +0200, David Jander wrote:
> Andrew Lunn <andrew@lunn.ch> wrote:
> > On Mon, May 23, 2022 at 04:20:09PM +0200, David Jander wrote:
> > > .attr = { .name = file, .mode = 0444 }, \
> > Not a criticism of this patch, but this is the old way to do this. It
> > is better to use DEVICE_ATTR_RO(), but that is a bigger rework.
> I suppose it is better to do this in a separate patch? @Mark, should I leave
> it as is, or do you require a "modernization" for this first?
I'd do it as a followup to this patch, that's just a random cleanup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-05-24 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 14:20 [PATCH] drivers: spi: spi.c: Convert statistics to per-cpu u64_stats_t David Jander
2022-05-23 15:13 ` Andrew Lunn
2022-05-23 18:56 ` Mark Brown
2022-05-24 6:25 ` David Jander
2022-05-24 11:46 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YozFgptOEr09+NMi@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@lunn.ch \
--cc=david@protonic.nl \
--cc=linux-spi@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).