Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jens Lindahl <jensctl@gmail.com>,
	linux-spi@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list 
	<bcm-kernel-feedback-list@broadcom.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>
Subject: Re: [PATCH] check if dma is active before attempting to terminate
Date: Mon, 6 Jun 2022 22:22:14 +0100	[thread overview]
Message-ID: <Yp5wBlOQfpTbUV/5@sirena.org.uk> (raw)
In-Reply-To: <6dae1c9d-89be-e1e5-2ea6-d6dbb56b8343@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

On Mon, Jun 06, 2022 at 11:17:57PM +0200, Florian Fainelli wrote:
> 
> 
> On 6/3/2022 4:23 PM, Jens Lindahl wrote:
> > ---
> >   drivers/spi/spi-bcm2835.c | 12 ++++++++----
> >   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> Your patch looks reasonable but is not properly formed:
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html

In particular:

You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2022-06-06 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 14:23 [PATCH] check if dma is active before attempting to terminate Jens Lindahl
2022-06-06 21:17 ` Florian Fainelli
2022-06-06 21:22   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yp5wBlOQfpTbUV/5@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=jensctl@gmail.com \
    --cc=linux-spi@vger.kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox