From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach
Date: Wed, 8 Jun 2022 15:23:27 +0300 [thread overview]
Message-ID: <YqCUv2tSwzALSVsm@smile.fi.intel.com> (raw)
In-Reply-To: <YqCQFFRXyaaQNSWv@kroah.com>
On Wed, Jun 08, 2022 at 02:03:32PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 08, 2022 at 02:49:14PM +0300, Andy Shevchenko wrote:
...
> Why not exactly? match_true() above and device_match_any() have the
> same signature from what I can tell:
> static int match_true(struct device *dev, void *data)
> int device_match_any(struct device *dev, const void *unused)
>
> What am I missing, the const?
Yep! Compiler is very unhappy about it.
> > I agree that all thing should be using _any instead of _first.
>
> Yes, so let's fix it please, don't propagate bad patterns.
Will do, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-08 12:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 20:20 [PATCH v1 1/2] driver core: Introduce device_find_first_child() helper Andy Shevchenko
2022-06-07 20:20 ` [PATCH v1 2/2] spi: Use device_find_first_child() instead of custom approach Andy Shevchenko
2022-06-08 11:30 ` Rafael J. Wysocki
2022-06-08 11:36 ` Greg Kroah-Hartman
2022-06-08 11:49 ` Andy Shevchenko
2022-06-08 12:03 ` Greg Kroah-Hartman
2022-06-08 12:23 ` Andy Shevchenko [this message]
2022-06-08 11:29 ` [PATCH v1 1/2] driver core: Introduce device_find_first_child() helper Rafael J. Wysocki
2022-06-08 11:53 ` Andy Shevchenko
2022-06-08 12:04 ` Greg Kroah-Hartman
2022-06-08 12:15 ` Rafael J. Wysocki
2022-06-08 12:23 ` Greg Kroah-Hartman
2022-06-08 13:32 ` Rafael J. Wysocki
2022-06-08 12:19 ` Rafael J. Wysocki
2022-06-08 11:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqCUv2tSwzALSVsm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).