From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI
Date: Tue, 4 Mar 2025 17:19:06 +0200 [thread overview]
Message-ID: <Z8cZ6jXFBnFRK7SE@black.fi.intel.com> (raw)
In-Reply-To: <nvym76w7ezhsugmno65m6jnt54ts5at7jcnn3jfrhlorayjlya@jyl536p2435u>
On Tue, Mar 04, 2025 at 07:48:42PM +0800, Inochi Amaoto wrote:
> On Tue, Mar 04, 2025 at 03:02:10PM +0800, Inochi Amaoto wrote:
> > The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
> > Add ACPI ID for it.
...
> > static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
> > {"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
> > + {"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
> > {},
> > };
> Drop this patch for now as the ACPI id is not registed.
Right, more details are in another thread:
https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com
And here is a formal NAK from me.
Thanks, Inochi, to take this into account!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-03-04 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 7:02 [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI Inochi Amaoto
2025-03-04 11:48 ` Inochi Amaoto
2025-03-04 15:19 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8cZ6jXFBnFRK7SE@black.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=looong.bin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).