* [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI
@ 2025-03-04 7:02 Inochi Amaoto
2025-03-04 11:48 ` Inochi Amaoto
0 siblings, 1 reply; 3+ messages in thread
From: Inochi Amaoto @ 2025-03-04 7:02 UTC (permalink / raw)
To: Mark Brown; +Cc: Inochi Amaoto, linux-spi, linux-kernel, Yixun Lan, Longbin Li
The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
Add ACPI ID for it.
Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
drivers/spi/spi-dw-mmio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index f0f576fac77a..70fdc4b6de9e 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -426,6 +426,7 @@ MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);
#ifdef CONFIG_ACPI
static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
{"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
+ {"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
{},
};
MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI
2025-03-04 7:02 [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI Inochi Amaoto
@ 2025-03-04 11:48 ` Inochi Amaoto
2025-03-04 15:19 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Inochi Amaoto @ 2025-03-04 11:48 UTC (permalink / raw)
To: Mark Brown; +Cc: Inochi Amaoto, linux-spi, linux-kernel, Yixun Lan, Longbin Li
On Tue, Mar 04, 2025 at 03:02:10PM +0800, Inochi Amaoto wrote:
> The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
> Add ACPI ID for it.
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> drivers/spi/spi-dw-mmio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
> index f0f576fac77a..70fdc4b6de9e 100644
> --- a/drivers/spi/spi-dw-mmio.c
> +++ b/drivers/spi/spi-dw-mmio.c
> @@ -426,6 +426,7 @@ MODULE_DEVICE_TABLE(of, dw_spi_mmio_of_match);
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
> {"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
> + {"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
> {},
> };
> MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
> --
> 2.48.1
>
Drop this patch for now as the ACPI id is not registed.
Regards,
Inochi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI
2025-03-04 11:48 ` Inochi Amaoto
@ 2025-03-04 15:19 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-03-04 15:19 UTC (permalink / raw)
To: Inochi Amaoto; +Cc: Mark Brown, linux-spi, linux-kernel, Yixun Lan, Longbin Li
On Tue, Mar 04, 2025 at 07:48:42PM +0800, Inochi Amaoto wrote:
> On Tue, Mar 04, 2025 at 03:02:10PM +0800, Inochi Amaoto wrote:
> > The Sophgo SG2044 SoC can enumerated its SPI device via ACPI.
> > Add ACPI ID for it.
...
> > static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
> > {"HISI0173", (kernel_ulong_t)dw_spi_pssi_init},
> > + {"SOPHO004", (kernel_ulong_t)dw_spi_pssi_init},
> > {},
> > };
> Drop this patch for now as the ACPI id is not registed.
Right, more details are in another thread:
https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com
And here is a formal NAK from me.
Thanks, Inochi, to take this into account!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-04 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-04 7:02 [PATCH] spi: dw: Add ACPI ID for the Sophgo SG2044 SoC SPI Inochi Amaoto
2025-03-04 11:48 ` Inochi Amaoto
2025-03-04 15:19 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).