[PATCH] spi: s3c64xx: add no_cs description

[PATCH] spi: s3c64xx: add no_cs description

[Jaewon Kim]

This patch adds missing variable no_cs descriptions.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
 include/linux/platform_data/spi-s3c64xx.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h
index 5df1ace6d2c9..3101152ce449 100644
--- a/include/linux/platform_data/spi-s3c64xx.h
+++ b/include/linux/platform_data/spi-s3c64xx.h
@@ -29,6 +29,7 @@ struct s3c64xx_spi_csinfo {
  * struct s3c64xx_spi_info - SPI Controller defining structure
  * @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field.
  * @num_cs: Number of CS this controller emulates.
+ * @no_cs: Used when CS line is not connected.
  * @cfg_gpio: Configure pins for this SPI controller.
  */
 struct s3c64xx_spi_info {
-- 
2.17.1

Re: [PATCH] spi: s3c64xx: add no_cs description

[Krzysztof Kozlowski]

On 06/03/2023 02:42, Jaewon Kim wrote:
> This patch adds missing variable no_cs descriptions.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] spi: s3c64xx: add no_cs description

[Andi Shyti]

Hi Jaewon,

On Mon, Mar 06, 2023 at 10:42:39AM +0900, Jaewon Kim wrote:
> This patch adds missing variable no_cs descriptions.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>

Reviewed-by: Andi Shyti <andi@etezian.org>

Thanks,
Andi

> ---
>  include/linux/platform_data/spi-s3c64xx.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h
> index 5df1ace6d2c9..3101152ce449 100644
> --- a/include/linux/platform_data/spi-s3c64xx.h
> +++ b/include/linux/platform_data/spi-s3c64xx.h
> @@ -29,6 +29,7 @@ struct s3c64xx_spi_csinfo {
>   * struct s3c64xx_spi_info - SPI Controller defining structure
>   * @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field.
>   * @num_cs: Number of CS this controller emulates.
> + * @no_cs: Used when CS line is not connected.
>   * @cfg_gpio: Configure pins for this SPI controller.
>   */
>  struct s3c64xx_spi_info {
> -- 
> 2.17.1

Re: [PATCH] spi: s3c64xx: add no_cs description

[Jaewon Kim]

Hello Mark


Could you apply this patch?

I missed you in the mail recipient.


https://lkml.org/lkml/2023/3/6/34

https://lkml.org/lkml/2023/3/6/232


On 23. 3. 6. 10:42, Jaewon Kim wrote:
> This patch adds missing variable no_cs descriptions.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>   include/linux/platform_data/spi-s3c64xx.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/platform_data/spi-s3c64xx.h b/include/linux/platform_data/spi-s3c64xx.h
> index 5df1ace6d2c9..3101152ce449 100644
> --- a/include/linux/platform_data/spi-s3c64xx.h
> +++ b/include/linux/platform_data/spi-s3c64xx.h
> @@ -29,6 +29,7 @@ struct s3c64xx_spi_csinfo {
>    * struct s3c64xx_spi_info - SPI Controller defining structure
>    * @src_clk_nr: Clock source index for the CLK_CFG[SPI_CLKSEL] field.
>    * @num_cs: Number of CS this controller emulates.
> + * @no_cs: Used when CS line is not connected.
>    * @cfg_gpio: Configure pins for this SPI controller.
>    */
>   struct s3c64xx_spi_info {


Thanks

Re: [PATCH] spi: s3c64xx: add no_cs description

[Krzysztof Kozlowski]

On 30/03/2023 15:40, Jaewon Kim wrote:
> Hello Mark
> 
> 
> Could you apply this patch?
> 
> I missed you in the mail recipient.
> 
> 
> https://lkml.org/lkml/2023/3/6/34
> 
> https://lkml.org/lkml/2023/3/6/232

I think you should resend. This time with entire output of
scripts/get_maintainers.pl

Best regards,
Krzysztof

Re: [PATCH] spi: s3c64xx: add no_cs description

[Jaewon Kim]

Hi Krzysztof


I always appreciate your kind guide.


I used 'get_maintainers.pl' but the Mark was missing.

Because the changes in this patch are only in 
"include/linux/platform_data/".

There was no touch in SPI driver. So, script did not outputting the SPI 
Maintainer.


Thanks

Jaewon Kim

On 23. 3. 30. 23:46, Krzysztof Kozlowski wrote:
> On 30/03/2023 15:40, Jaewon Kim wrote:
>> Hello Mark
>>
>>
>> Could you apply this patch?
>>
>> I missed you in the mail recipient.
>>
>>
>> https://protect2.fireeye.com/v1/url?k=62c6672d-034d7217-62c7ec62-74fe4860008a-45c729ef051007d6&q=1&e=03453742-6822-4fdc-9ee7-bdb6bdb0fe4f&u=https%3A%2F%2Flkml.org%2Flkml%2F2023%2F3%2F6%2F34
>>
>> https://protect2.fireeye.com/v1/url?k=41253bbb-20ae2e81-4124b0f4-74fe4860008a-f6ba8ee97b64390d&q=1&e=03453742-6822-4fdc-9ee7-bdb6bdb0fe4f&u=https%3A%2F%2Flkml.org%2Flkml%2F2023%2F3%2F6%2F232
> I think you should resend. This time with entire output of
> scripts/get_maintainers.pl
>
> Best regards,
> Krzysztof
>
>

Re: [PATCH] spi: s3c64xx: add no_cs description

[Mark Brown]

On Mon, 06 Mar 2023 10:42:39 +0900, Jaewon Kim wrote:
> This patch adds missing variable no_cs descriptions.
> 
> 

Applied to

   broonie/spi.git for-next

Thanks!

[1/1] spi: s3c64xx: add no_cs description
      commit: e3d53ded577328f2b26d361f2e62fc70e85ab6a3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark