From: andy.shevchenko@gmail.com
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Michael Peters <mpeters@embeddedts.com>,
Kris Bahnsen <kris@embeddedts.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 18/43] spi: ep93xx: add DT support for Cirrus EP93xx
Date: Sat, 3 Jun 2023 23:27:21 +0300 [thread overview]
Message-ID: <ZHuiKT-CezPbPDkh@surfacebook> (raw)
In-Reply-To: <20230601053546.9574-19-nikita.shubin@maquefel.me>
Thu, Jun 01, 2023 at 08:34:09AM +0300, Nikita Shubin kirjoitti:
> - find register range from the device tree
> - provide clock access via of
> - use_dma as a DT node
...
> +static struct ep93xx_spi_info *ep93xx_spi_get_platdata(struct platform_device *pdev)
> +{
> + struct device_node *np = pdev->dev.of_node;
> + if (np && of_property_read_bool(np, "ep9301,use-dma"))
Excessive check for np to be NULL, this is implied by the _read_bool() anyway.
> + dt_spi_info.use_dma = 1;
> + return &dt_spi_info;
> +}
...
> + master->dev.of_node = pdev->dev.of_node;
device_set_node();
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-06-03 20:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 12:34 [PATCH 00/43] ep93xx device tree conversion Nikita Shubin
2023-04-24 11:31 ` Arnd Bergmann
[not found] ` <20230424152933.48b2ede1@kernel.org>
2023-04-25 9:20 ` Krzysztof Kozlowski
2023-04-25 13:27 ` Arnd Bergmann
2023-04-24 12:34 ` [PATCH 16/43] dt-bindings: spi: Add DT bindings ep93xx spi Nikita Shubin
2023-04-24 15:54 ` Mark Brown
2023-04-24 16:08 ` Rob Herring
2023-04-24 12:34 ` [PATCH 17/43] spi: ep93xx: add DT support for Cirrus EP93xx Nikita Shubin
2023-04-24 11:34 ` Alexander Sverdlin
2023-04-26 20:42 ` Linus Walleij
2023-04-26 20:56 ` [PATCH 00/43] ep93xx device tree conversion Linus Walleij
[not found] ` <b5396ef5-3fed-4e98-8f37-a9cd4473bddc@sirena.org.uk>
2023-04-26 21:06 ` Linus Walleij
2023-05-16 3:47 ` Florian Fainelli
2023-05-16 10:37 ` Nikita Shubin
2023-06-01 5:34 ` [PATCH v1 17/43] dt-bindings: spi: Add Cirrus EP93xx Nikita Shubin
2023-06-01 8:16 ` Krzysztof Kozlowski
2023-06-01 11:17 ` Mark Brown
2023-06-01 12:41 ` Nikita Shubin
2023-06-01 12:55 ` Mark Brown
2023-06-01 13:15 ` Nikita Shubin
2023-06-01 5:34 ` [PATCH v1 18/43] spi: ep93xx: add DT support for " Nikita Shubin
2023-06-03 20:27 ` andy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHuiKT-CezPbPDkh@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kris@embeddedts.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mpeters@embeddedts.com \
--cc=nikita.shubin@maquefel.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).