From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Yang Yingliang" <yangyingliang@huawei.com>,
"Amit Kumar Mahapatra via Alsa-devel"
<alsa-devel@alsa-project.org>,
"Kris Bahnsen" <kris@embeddedts.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Tharun Kumar P" <tharunkumar.pasumarthi@microchip.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
"Radu Pirea" <radu_nicolae.pirea@upb.ro>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Alain Volmat" <alain.volmat@foss.st.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Richard Cochran" <richardcochran@gmail.com>
Subject: Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X
Date: Mon, 10 Jul 2023 16:32:09 +0300 [thread overview]
Message-ID: <ZKwIWUeqD/otnSFM@smile.fi.intel.com> (raw)
In-Reply-To: <7aff8759-cfca-47b5-b995-5260e5082c45@sirena.org.uk>
On Mon, Jul 10, 2023 at 02:21:05PM +0100, Mark Brown wrote:
> On Mon, Jul 10, 2023 at 03:37:59PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 10, 2023 at 12:22:59PM +0100, Mark Brown wrote:
> > > On Mon, Jul 10, 2023 at 02:10:53PM +0300, Andy Shevchenko wrote:
...
> > > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X
> > > > > > > and kill the not used anymore definitions.
...
> > > > > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX;
> > > > > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX;
>
> > > What part of the above change is replacing _NO_ with _MUST_?
>
> > None, that's why assuming the split by name should be fine.
>
> That's what the above changelog sounds like it's trying to do (I'm not
> sure the change itself makes sense but the first thing I ran into when
> reviewing the patch), AFIACT you're missing a "from" in the changelog?
I see, I will elaborate better in v2.
But still, I will split on per macro and add one for GPIO_SS.
Seems to me better that way.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-10 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 10:27 [PATCH v1 0/8] spi: Header and core clean up and refactoring Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 1/8] spi: Remove unneeded OF node NULL checks Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 2/8] spi: Drop duplicate IDR allocation code in spi_register_controller() Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 3/8] spi: Use sysfs_emit() to instead of s*printf() Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Andy Shevchenko
2023-07-10 11:04 ` Mark Brown
2023-07-10 11:08 ` Andy Shevchenko
2023-07-10 11:10 ` Mark Brown
2023-07-10 11:19 ` Andy Shevchenko
2023-07-10 11:10 ` Andy Shevchenko
2023-07-10 11:22 ` Mark Brown
2023-07-10 12:37 ` Andy Shevchenko
2023-07-10 13:21 ` Mark Brown
2023-07-10 13:32 ` Andy Shevchenko [this message]
2023-07-10 10:27 ` [PATCH v1 5/8] spi: Sort headers alphabetically Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 6/8] spi: Clean up headers Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 7/8] spi: Fix spelling typos and acronyms capitalization Andy Shevchenko
2023-07-10 10:27 ` [PATCH v1 8/8] spi: Use struct_size() helper Andy Shevchenko
2023-07-10 13:36 ` [PATCH v1 0/8] spi: Header and core clean up and refactoring Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKwIWUeqD/otnSFM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=jbrunet@baylibre.com \
--cc=jcmvbkbc@gmail.com \
--cc=khilman@baylibre.com \
--cc=kris@embeddedts.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richardcochran@gmail.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=tudor.ambarus@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).