From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32BAEB64D9 for ; Mon, 10 Jul 2023 13:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232659AbjGJNeL (ORCPT ); Mon, 10 Jul 2023 09:34:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232810AbjGJNd6 (ORCPT ); Mon, 10 Jul 2023 09:33:58 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A5BC129; Mon, 10 Jul 2023 06:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688996019; x=1720532019; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PcgdfCqBIbPTu4JqQZu5q+HYQGpr7DWOm49hDVjk5i0=; b=e7qqbQY6u2HuARziO0B/Mt3VvTWem5sUQhzIDLNQIHcV4mNnKM6d2TY6 fYLDtt6YKPx15U7x9w+AwvXfC31dVX4rV+pS7pz6sfFnXPNrmqkHKH8Xa c5PD3pnnqvo4UZ4U7CRFbd6EtMv3joaA7SXc/OGkP1m+xmBaBAJwjp4WX 97u45KrVE4uGafIJ8qLCO0wuwa5e953Y8H4olRcasXVSVCaQ/MhojaXMq Dpl/wp6VQy/TNnAiJP/dD9gl/ZMfAR5JbaM3dxgFiKblc0U69Yjmu6wzX cwmxl5Z+eyVYmkq932J3z3A+xlgCHegF7UZ3jxrNI9eNJoZKgofnBtlAc A==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="428037965" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="428037965" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 06:32:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="790802176" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="790802176" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 10 Jul 2023 06:32:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qIqzq-001Z8L-0E; Mon, 10 Jul 2023 16:32:10 +0300 Date: Mon, 10 Jul 2023 16:32:09 +0300 From: Andy Shevchenko To: Mark Brown Cc: Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Kris Bahnsen , Neil Armstrong , Tharun Kumar P , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Richard Cochran Subject: Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Message-ID: References: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> <20230710102751.83314-5-andriy.shevchenko@linux.intel.com> <1ffd5603-4140-4bf6-bfed-af70a6759bda@sirena.org.uk> <353027bf-6d2a-40de-9e18-8553864b343c@sirena.org.uk> <7aff8759-cfca-47b5-b995-5260e5082c45@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7aff8759-cfca-47b5-b995-5260e5082c45@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Mon, Jul 10, 2023 at 02:21:05PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 03:37:59PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 10, 2023 at 12:22:59PM +0100, Mark Brown wrote: > > > On Mon, Jul 10, 2023 at 02:10:53PM +0300, Andy Shevchenko wrote: ... > > > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > > > > > and kill the not used anymore definitions. ... > > > > > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > > > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; > > > > What part of the above change is replacing _NO_ with _MUST_? > > > None, that's why assuming the split by name should be fine. > > That's what the above changelog sounds like it's trying to do (I'm not > sure the change itself makes sense but the first thing I ran into when > reviewing the patch), AFIACT you're missing a "from" in the changelog? I see, I will elaborate better in v2. But still, I will split on per macro and add one for GPIO_SS. Seems to me better that way. -- With Best Regards, Andy Shevchenko