From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC1A0E728F1 for ; Fri, 29 Sep 2023 20:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233173AbjI2ULA (ORCPT ); Fri, 29 Sep 2023 16:11:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbjI2UK7 (ORCPT ); Fri, 29 Sep 2023 16:10:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C81BCDE; Fri, 29 Sep 2023 13:10:57 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADE54C433C8; Fri, 29 Sep 2023 20:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696018257; bh=1M4BkuC30Zeg4355NfbrbsY3DVOz7+6NsJVVtiT81CQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gA5o4RmSuwc80uSa2FJJ9G6CETji9We2MVjP6A1z3+OLU0ySHC64ntj0DeAxQf4oD zKRfN4JgrHjfZkD8oNVUh4n9F6pziC0HB2U89hn6v5oCyU5Kpg4pdb6Oo6yCc5eUZq WFeVR4LDdLmRwobKPoEtA6MbLb5YA+CIc7YSn51RomzZ5zNFYqbGnIE24balob7DM2 kfnhVvowL42I3/2PE/se3SxTHhwi/gAbDq0qjj5koRgIC+whOgfovEIsWi645/7ef3 U1GnkhbBrsL5kGiBAsuU2F6h981v+rHhQD2LQTps6yFJZhBVZz0QMe2qGHahJ0VwjF 70TLeL7FRsZHA== Date: Fri, 29 Sep 2023 22:10:48 +0200 From: Wolfram Sang To: "Wu, Wentong" Cc: "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "mka@chromium.org" , "oneukum@suse.com" , "lee@kernel.org" , "kfting@nuvoton.com" , "broonie@kernel.org" , "linus.walleij@linaro.org" , "hdegoede@redhat.com" , "maz@kernel.org" , "brgl@bgdev.pl" , "linux-usb@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "andriy.shevchenko@linux.intel.com" , "heikki.krogerus@linux.intel.com" , "andi.shyti@linux.intel.com" , "sakari.ailus@linux.intel.com" , "bartosz.golaszewski@linaro.org" , "Pandruvada, Srinivas" , "Wang, Zhifeng" Subject: Re: [PATCH v19 2/4] i2c: Add support for Intel LJCA USB I2C driver Message-ID: Mail-Followup-To: Wolfram Sang , "Wu, Wentong" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "mka@chromium.org" , "oneukum@suse.com" , "lee@kernel.org" , "kfting@nuvoton.com" , "broonie@kernel.org" , "linus.walleij@linaro.org" , "hdegoede@redhat.com" , "maz@kernel.org" , "brgl@bgdev.pl" , "linux-usb@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "andriy.shevchenko@linux.intel.com" , "heikki.krogerus@linux.intel.com" , "andi.shyti@linux.intel.com" , "sakari.ailus@linux.intel.com" , "bartosz.golaszewski@linaro.org" , "Pandruvada, Srinivas" , "Wang, Zhifeng" References: <1694890416-14409-1-git-send-email-wentong.wu@intel.com> <1694890416-14409-3-git-send-email-wentong.wu@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="o7iWeLNBu+rG+qYi" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org --o7iWeLNBu+rG+qYi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > And with i2cdetect -q busnum, I see error on driver side which enable > I2C_FUNC_SMBUS_EMUL and not disable I2C_FUNC_SMBUS_QUICK, I think > it means we don't support zero-length transfer if I understand correctly. At least, not currently. Sometimes the driver just needs updates, sometimes the HW simply cannot do it. If it is a software issue, we can fix it incrementally. > static u32 ljca_i2c_func(struct i2c_adapter *adap) > { > return I2C_FUNC_I2C | (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > } Yes. > static const struct i2c_adapter_quirks ljca_i2c_quirks = { > .flags = I2C_AQ_NO_ZERO_LEN, > .max_read_len = LJCA_I2C_MAX_XFER_SIZE, > .max_write_len = LJCA_I2C_MAX_XFER_SIZE, > }; Yes. I think the I2C driver is good then. --o7iWeLNBu+rG+qYi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUXL0QACgkQFA3kzBSg KbZ+2xAAgGOyccHg6fDXYczXy+M2IiVYbUi0VhGvsFiI+tNBZTh+AUTsGwFEJq7e smcPWBROSUVOGtrkHUuxLfx960qjGWSJ2+DL8pwp9UleGXm/Kc748IR8/zNA/UzL FHxgymaeTNtl6m4+6FsGrZlIdK524IGzW2e9PfB3CG7qLFOME/hjdAvnpdqRLt1y oxK32COXBkUn1nHGnFhjrx5dwZSpTsR1STtcMDeoJ8IR1pquOB0/kUSd64nfIm6T jSfafZRCBX+7qEUxQMm+1bppZAB8nLloJMU4cdwdzhgOJx1mcs4QiMkoP8FNmBqZ jpnzrtYPGYuNn/Y7In19UkPuerXe+TfIAdeQSBnjC9nqVjlfGRShLlo/+rTB+4We LkZWvlKwXNE3gNbAOlJB9IFUP2KzfX6UgaVFqImvWFutKebWD5JI9KkulOAobKkA pBTK1xcn6hmOP/znssTZWNoCDCiVEkIK1cBzXB75QTIx1iwWBwHBMCTdoHyhCr2V +jkirMxNtY75qcXfRC0Qk+foryj/dFVbu7Hem1YvRVH51rRBz58Oyay27pEBC0uI /OQ3eJ1F9Fdn3O28DiswzDoNpoIyK9FHCYLoA1hD5Vv5y8sA+DeWEfPTdWVik+cD AY3NIfklZhIXgfp3Hh6YLZGNDOmOd/bSwwmVqwF2GKAXc5nv5i4= =bpEP -----END PGP SIGNATURE----- --o7iWeLNBu+rG+qYi--