From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EC6C4332F for ; Mon, 30 Oct 2023 08:48:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231945AbjJ3IsT (ORCPT ); Mon, 30 Oct 2023 04:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjJ3IsT (ORCPT ); Mon, 30 Oct 2023 04:48:19 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC6D94; Mon, 30 Oct 2023 01:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698655696; x=1730191696; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LS2pJUDiSTV423qSWLXmXIRDuZGAYUxp6qKMrJfujok=; b=TIgKY1buvMEgrpzxDzhdtGcbh5vQLpNEIPwcMUYWDghKiPJ5/on4tepb G/lv30pUdYEGSTsCs1hYYSSzbAt8oI4Lsca3WcRIIUCaJMrwY6wSKT+CE avGl7BKQNbkavuWtLRmcUxJ6JZe/io2eXsPMQxWtluxhHr/4cx8i+nAa+ 5O0XgePoRoHVcOq6kfoGvjzQwdY806/DulpO+QLGL6l8Z0jQyJI4tVOgF LXbDQzak+Hx4rZKxiGPijJKmb5y5uZPqDnhVNy2yG01uqP3OdT92j2e/D ZR5qaFFg5MftJ/aqb9x4s2wsk4qsj+1HJYMxQa+C2Qwe/AqkDepZs+ElS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="368251134" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="368251134" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 01:48:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="933719934" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="933719934" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 01:48:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qxNwO-00000009mXD-2f7u; Mon, 30 Oct 2023 10:48:08 +0200 Date: Mon, 30 Oct 2023 10:48:08 +0200 From: Andy Shevchenko To: Mark Brown , Rob Herring , Frank Rowand Cc: "Stoll, Eberhard" , Miquel Raynal , Eberhard Stoll , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "Schrempf, Frieder" , Amit Kumar Mahapatra , Christophe JAILLET , Geert Uytterhoeven , Krishna Yarlagadda , Leonard =?iso-8859-1?Q?G=F6hrs?= , Yang Yingliang Subject: Re: AW: [PATCH 1/4] spi: Add parameter for clock to rx delay Message-ID: References: <20231026152316.2729575-1-estl@gmx.net> <20231026152316.2729575-2-estl@gmx.net> <20231027005643.4b95f17e@xps-13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Fri, Oct 27, 2023 at 04:45:25PM +0100, Mark Brown wrote: > On Fri, Oct 27, 2023 at 02:46:42PM +0300, Andy Shevchenko wrote: > > > So, to me sounds like device tree source issue. I.e. you need to provide > > different DT(b)s depending on the platform (and how it should be). > > The cleanest solution (as I see not the first time people I trying quirks like > > this to be part of the subsystems / drivers) is to make DT core (OF) to have > > conditionals or boot-time modifications allowed. > > > This, what you are doing, does not scale and smells like an ugly hack. > > No, this seems like an entirely reasonable thing to have - it's just a > property of the device, we don't need to add a DT property for it, and > the maximum speed that the device can run at is going to vary depending > on the ability of the controller to control the sampling point. > > As people have been saying there's a particularly clear case for this > with SPI flash which is probed at runtime and is readily substituted at > the hardware level. So, then the question is what does DT _actually_ describes? If we have an autoprobe of something that doesn't work on platform A and works on platform B, shouldn't these platforms have to have distinguishable DTs? -- With Best Regards, Andy Shevchenko