From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h
Date: Thu, 7 Mar 2024 13:20:47 +0200 [thread overview]
Message-ID: <ZemjDwEs8qdix2n0@smile.fi.intel.com> (raw)
In-Reply-To: <9ac09714-25e6-429f-8847-0ee6a34e0220@sirena.org.uk>
On Mon, Mar 04, 2024 at 05:10:22PM +0000, Mark Brown wrote:
> On Mon, Mar 04, 2024 at 04:42:55PM +0200, Andy Shevchenko wrote:
> > On Wed, Feb 28, 2024 at 09:37:31PM +0200, Andy Shevchenko wrote:
> > > of_gpio.h is deprecated and subject to remove.
> > > The driver doesn't use it, simply remove the unused header.
>
> > Hmm... did it fall through cracks or anything should I do?
>
> Please don't send content free pings and please allow a reasonable time
> for review. People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review. If there have been
> review comments then people may be waiting for those to be addressed.
>
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.
Right, but it looks like this is quite simple one that simply got unnoticed
or so...
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-03-07 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:37 [PATCH v1 1/1] spi: oc-tiny: Remove unused of_gpio.h Andy Shevchenko
2024-03-04 14:42 ` Andy Shevchenko
2024-03-04 17:10 ` Mark Brown
2024-03-07 11:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZemjDwEs8qdix2n0@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox