From: Colin Foster <colin.foster@in-advantage.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: omap2-mcspi multi mode
Date: Tue, 4 Jun 2024 22:04:49 -0500 [thread overview]
Message-ID: <Zl/V0dU6SjAMkpLG@colin-ia-desktop> (raw)
Hi Louis,
I found that commit e64d3b6fc9a3 ("spi: omap2-mcpsi: Enable MULTI-mode
in more situations") caused a regression in the ocelot_mfd driver. It
essentially causes the boot to hang during probe of the SPI device.
The following patch restores functionality. I can hook up a logic
analyzer tomorrow to get some more info, but I wanted to see if you had
any ideas.
--- a/drivers/mfd/ocelot-spi.c
+++ b/drivers/mfd/ocelot-spi.c
@@ -225,6 +228,8 @@ static int ocelot_spi_probe(struct spi_device *spi)
}
spi->bits_per_word = 8;
+ spi->word_delay.value = 1;
+ spi->word_delay.unit = SPI_DELAY_UNIT_NSECS;
err = spi_setup(spi);
if (err)
Colin Foster
next reply other threads:[~2024-06-05 3:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 3:04 Colin Foster [this message]
2024-06-06 8:06 ` omap2-mcspi multi mode Louis Chauvet
2024-06-07 3:14 ` Colin Foster
2024-06-07 15:45 ` Mark Brown
2024-06-11 14:21 ` Colin Foster
2024-06-21 8:21 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-21 16:56 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl/V0dU6SjAMkpLG@colin-ia-desktop \
--to=colin.foster@in-advantage.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).