[PATCH v1 1/1] spi: Replace custom code with device_match_acpi_handle()

[PATCH v1 1/1] spi: Replace custom code with device_match_acpi_handle()

[Andy Shevchenko]

Since driver core provides a generic device_match_acpi_handle()
we may replace the custom code with it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index ef0027b9cae5..b2efd4964f7c 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2712,7 +2712,7 @@ static int acpi_spi_add_resource(struct acpi_resource *ares, void *data)
 				return -ENODEV;
 
 			if (ctlr) {
-				if (ACPI_HANDLE(ctlr->dev.parent) != parent_handle)
+				if (!device_match_acpi_handle(ctlr->dev.parent, parent_handle))
 					return -ENODEV;
 			} else {
 				struct acpi_device *adev;
@@ -2811,7 +2811,7 @@ struct spi_device *acpi_spi_device_alloc(struct spi_controller *ctlr,
 
 	if (!lookup.max_speed_hz &&
 	    ACPI_SUCCESS(acpi_get_parent(adev->handle, &parent_handle)) &&
-	    ACPI_HANDLE(lookup.ctlr->dev.parent) == parent_handle) {
+	    device_match_acpi_handle(lookup.ctlr->dev.parent, parent_handle)) {
 		/* Apple does not use _CRS but nested devices for SPI slaves */
 		acpi_spi_parse_apple_properties(adev, &lookup);
 	}
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] spi: Replace custom code with device_match_acpi_handle()

[Andy Shevchenko]

On Fri, May 10, 2024 at 11:49:52PM +0300, Andy Shevchenko wrote:
> Since driver core provides a generic device_match_acpi_handle()
> we may replace the custom code with it.

Hmm... Other more recent patches went through, is this lost in cracks?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] spi: Replace custom code with device_match_acpi_handle()

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

On Thu, Jun 06, 2024 at 12:08:35AM +0300, Andy Shevchenko wrote:
> On Fri, May 10, 2024 at 11:49:52PM +0300, Andy Shevchenko wrote:
> > Since driver core provides a generic device_match_acpi_handle()
> > we may replace the custom code with it.

> Hmm... Other more recent patches went through, is this lost in cracks?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 1/1] spi: Replace custom code with device_match_acpi_handle()

[Andy Shevchenko]

On Wed, Jun 05, 2024 at 10:22:13PM +0100, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 12:08:35AM +0300, Andy Shevchenko wrote:
> > On Fri, May 10, 2024 at 11:49:52PM +0300, Andy Shevchenko wrote:
> > > Since driver core provides a generic device_match_acpi_handle()
> > > we may replace the custom code with it.
> 
> > Hmm... Other more recent patches went through, is this lost in cracks?

Found it, it's an announce that is missing, thanks!

-- 
With Best Regards,
Andy Shevchenko