From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Conor Dooley <conor@kernel.org>
Cc: "Szőke Benjamin" <egyszeregy@freemail.hu>,
"Mark Brown" <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spidev: Introduce "linux,spidev-name" property for device tree of spidev.
Date: Tue, 11 Jun 2024 13:41:02 +0300 [thread overview]
Message-ID: <ZmgpvimPgEugxJk4@surfacebook.localdomain> (raw)
In-Reply-To: <20240607-upcoming-tidiness-401e5d0a8af0@spud>
Fri, Jun 07, 2024 at 05:07:23PM +0100, Conor Dooley kirjoitti:
> On Sun, Jun 02, 2024 at 05:31:10PM +0200, Szőke Benjamin wrote:
>
> > spidev@0 {
> > reg = <0>;
> > compatible = "rohm,dh2228fv";
> > spi-max-frequency = <1000000>;
> >
> > // via my kernel patch -> /dev/spidev-mysensor
> > // linux,spidev-name = "mysensor";
>
> Given you are describing a DAC as a "sensor", I doubt you actually even
> have a dh2228fv*. You're looking to have a consistent name here, but you
> can't even rely on Linux even continuing to bind the spidev driver
> against this compatible if somebody comes along and writes an IIO driver
> for this DAC!
>
> That said, google seems to return no results for a dh2228fv, only for a
> bh2228fv. Makes me wonder if this device actually even exists...
Why not summon Matti?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-06-11 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-19 21:13 [PATCH v2] spidev: Introduce "linux,spidev-name" property for device tree of spidev egyszeregy
2024-05-20 13:20 ` Mark Brown
2024-05-20 17:20 ` Szőke Benjamin
2024-05-20 20:14 ` Mark Brown
2024-06-02 15:31 ` Szőke Benjamin
2024-06-07 15:55 ` Mark Brown
2024-06-07 16:07 ` Conor Dooley
2024-06-11 10:41 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmgpvimPgEugxJk4@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=conor@kernel.org \
--cc=egyszeregy@freemail.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).