From: Colin Foster <colin.foster@in-advantage.com>
To: Mark Brown <broonie@kernel.org>,
Louis Chauvet <louis.chauvet@bootlin.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
miquel.raynal@bootlin.com
Subject: Re: omap2-mcspi multi mode
Date: Tue, 11 Jun 2024 09:21:15 -0500 [thread overview]
Message-ID: <ZmhdWw/dV5HRU/Nh@colin-ia-desktop> (raw)
In-Reply-To: <ZmMrJ8uaw85a03Ce@finisterre.sirena.org.uk>
Hi Louis,
On Fri, Jun 07, 2024 at 04:45:43PM +0100, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 10:14:27PM -0500, Colin Foster wrote:
>
> > So I think the question I have is:
>
> > Should the CS line be de-asserted at the end of "spi_write"?
>
> Absent bodging with cs_change after any spi message the chip select
> should be left deasserted.
Do you have hardware to reproduce my results of two spi messages no
longer toggling the CS line and leaving the line at GND through the
transactions?
next prev parent reply other threads:[~2024-06-11 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 3:04 omap2-mcspi multi mode Colin Foster
2024-06-06 8:06 ` Louis Chauvet
2024-06-07 3:14 ` Colin Foster
2024-06-07 15:45 ` Mark Brown
2024-06-11 14:21 ` Colin Foster [this message]
2024-06-21 8:21 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-21 16:56 ` Colin Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmhdWw/dV5HRU/Nh@colin-ia-desktop \
--to=colin.foster@in-advantage.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).