Linux SPI subsystem development
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage.com>
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Mark Brown <broonie@kernel.org>,
	Louis Chauvet <louis.chauvet@bootlin.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	miquel.raynal@bootlin.com
Subject: Re: omap2-mcspi multi mode
Date: Fri, 21 Jun 2024 11:56:35 -0500	[thread overview]
Message-ID: <ZnWww9CF365YjF6P@colin-ia-desktop> (raw)
In-Reply-To: <acaf2d70-d821-4951-9072-931cb56b1b9f@leemhuis.info>

Hi Thorsten,

On Fri, Jun 21, 2024 at 10:21:26AM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 11.06.24 16:21, Colin Foster wrote:
> > On Fri, Jun 07, 2024 at 04:45:43PM +0100, Mark Brown wrote:
> >> On Thu, Jun 06, 2024 at 10:14:27PM -0500, Colin Foster wrote:
> >>
> >>> So I think the question I have is:
> >>
> >>> Should the CS line be de-asserted at the end of "spi_write"?
> >>
> >> Absent bodging with cs_change after any spi message the chip select
> >> should be left deasserted.
> > 
> > Do you have hardware to reproduce my results of two spi messages no
> > longer toggling the CS line and leaving the line at GND through the
> > transactions?
> 
> Hmmm, I might have missed something, but it looks like nothing happened
> since that exchange. Did this regression fall through the cracks or can
> I consider the issue resolved for some reason?
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

No, you haven't missed anything. This still feels like a regression to
me, but historically "regressions" I've found end up being a
misconfiguration on my part. I'm travelling this week so it won't be
until next week / weekend that I can get to anything.

I'll plan to look into a fix if it is indeed an issue.

Colin Foster

      reply	other threads:[~2024-06-21 16:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  3:04 omap2-mcspi multi mode Colin Foster
2024-06-06  8:06 ` Louis Chauvet
2024-06-07  3:14   ` Colin Foster
2024-06-07 15:45     ` Mark Brown
2024-06-11 14:21       ` Colin Foster
2024-06-21  8:21         ` Linux regression tracking (Thorsten Leemhuis)
2024-06-21 16:56           ` Colin Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnWww9CF365YjF6P@colin-ia-desktop \
    --to=colin.foster@in-advantage.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox