From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D0A717A924 for ; Fri, 20 Sep 2024 14:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726843347; cv=none; b=gG0yDJ1CKlKgz48vVNucVZ944RL0oCiZunfzdIInTLoMGwP4L4e0f4slSIpitG0ZaU1w578WPpXjq6M57nGW+24YLEPzelDCXilPNeYDEEAU+PBhKjd25mWMTRagAGStNs6DLg3rLZg4WmQXR07/J2tiiPbfARFf+niDkiUubgk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726843347; c=relaxed/simple; bh=Byzt261dQ/GR0ge5mgHVVMKv2pKoBD8K6PZ6vkTEjpM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jmffIcD3o7RymgLDd2QFGrSG3SNLhbN37w+bVHFkh/hijjcqPW3cTGjw7YUZ8a5fRD6ND/2CExf2KqMqGafR27OCRiGy+WoShSCWBEW1kFtATH1ZVedCZLKvr7zkHXTJE84mqSoXU7ABzYA1gGYMUevJVcwqGKlF71Loh0IyO1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J5ALdZMB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J5ALdZMB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F817C4CEC3; Fri, 20 Sep 2024 14:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726843347; bh=Byzt261dQ/GR0ge5mgHVVMKv2pKoBD8K6PZ6vkTEjpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J5ALdZMB9sxFhfVJojkkcFCVh1m+QyOaHtb3W8QWp8mYqWSqkmnbCkt2fVHeCY1Sd plMzzveNUf1StABzr6xfiIz1yXkfWMpZjWXb41q+A91+qU8VXrgBdkUVjZEfUvSXxd 5aXRPmzD1fM58mcPgYeoGochH0vcRJtzEkCx1CO+7eg5LMF0tlIGz5hM54y2615spK MpoeadzQA5BZGjK5nd7GdDeACnQmn4HxqTXAEYSO62Z609l7JDHGN6jRDBHnRvk6Sw B47Lf0V6VyGRCIWvotBqegFWbMNb1lwoc6ARh8DD4+xZMYjV5vLYzPnTEb6od6EEcq E5MvYsYewZV2w== Date: Fri, 20 Sep 2024 16:42:24 +0200 From: Lorenzo Bianconi To: Andy Shevchenko Cc: Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Christian Marangi , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, upstream@airoha.com Subject: Re: [PATCH v2 2/2] spi: airoha: do not keep {tx,rx} dma buffer always mapped Message-ID: References: <20240919-airoha-spi-fixes-v2-0-cb0f0ed9920a@kernel.org> <20240919-airoha-spi-fixes-v2-2-cb0f0ed9920a@kernel.org> Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pjTKbbGz/7+vpOLe" Content-Disposition: inline In-Reply-To: --pjTKbbGz/7+vpOLe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sep 20, Andy Shevchenko wrote: > On Thu, Sep 19, 2024 at 06:57:17PM +0200, Lorenzo Bianconi wrote: > > DMA map txrx_buf on demand in airoha_snand_dirmap_read and > > airoha_snand_dirmap_write routines and do not keep it always mapped. > > This patch is not fixing any bug or introducing any functional change > > to the driver, it just simplifies the code and improve code readability > > without introducing any performance degradation according to the results > > obtained from the mtd_speedtest kernel module test. >=20 > ... >=20 > > + dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SI= ZE, > > + DMA_FROM_DEVICE); > > + if (dma_mapping_error(as_ctrl->dev, dma_addr)) > > + return -ENOMEM; >=20 > Shouldn't this be >=20 > err =3D dma_mapping_error(as_ctrl->dev, dma_addr); > if (err) > return err; >=20 > ? >=20 > ... >=20 > > + dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SI= ZE, > > + DMA_TO_DEVICE); > > + if (dma_mapping_error(as_ctrl->dev, dma_addr)) > > + return -ENOMEM; >=20 > Ditto. >=20 > --=20 > With Best Regards, > Andy Shevchenko >=20 >=20 ack, I will fix it in v3. Rergards, Lorenzo --pjTKbbGz/7+vpOLe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZu2JzwAKCRA6cBh0uS2t rMDqAP9vNRdg/h86aMIz+MIO0oeMbw/00o1VpEWcFMIdRv+4IgD/atNg1EU3qL5d jC/aN8OCB4xEhNztf9ICc7I6pw7Yjwg= =/xyN -----END PGP SIGNATURE----- --pjTKbbGz/7+vpOLe--