From: Yang Yingliang <yangyingliang@huawei.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: <linux-doc@vger.kernel.org>, <linux-spi@vger.kernel.org>,
<corbet@lwn.net>, <broonie@kernel.org>,
<yangyingliang@huawei.com>
Subject: Re: [PATCH -next] Documentation: devres: add missing SPI helper
Date: Fri, 23 Sep 2022 14:32:42 +0800 [thread overview]
Message-ID: <a61fd394-978f-1a12-b38e-2f3ab8ad02f7@huawei.com> (raw)
In-Reply-To: <20220923055518.GA17668@wunner.de>
Hi Lukas,
On 2022/9/23 13:55, Lukas Wunner wrote:
> On Sat, Sep 17, 2022 at 08:26:39PM +0800, Yang Yingliang wrote:
>> Add devm_spi_alloc_master() and devm_spi_alloc_slave() to devres.rst.
>> They are introduced by commit 5e844cc37a5c ("spi: Introduce device-managed
>> SPI controller allocation").
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> Documentation/driver-api/driver-model/devres.rst | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
>> index 76cc256c9e4f..1bd6f38dd7e3 100644
>> --- a/Documentation/driver-api/driver-model/devres.rst
>> +++ b/Documentation/driver-api/driver-model/devres.rst
>> @@ -437,6 +437,8 @@ SLAVE DMA ENGINE
>>
>> SPI
>> devm_spi_register_master()
>> + devm_spi_alloc_master()
>> + devm_spi_alloc_slave()
>>
>> WATCHDOG
>> devm_watchdog_register_device()
> Putting the alloc functions above the register function would
> probably be more in line with how they're used. Apart from that:
Do I need send a v2 to move up alloc functions with your review tag.
Thanks,
Yang
>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> .
next prev parent reply other threads:[~2022-09-23 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 12:26 [PATCH -next] Documentation: devres: add missing SPI helper Yang Yingliang
2022-09-23 5:55 ` Lukas Wunner
2022-09-23 6:32 ` Yang Yingliang [this message]
2022-09-23 11:54 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a61fd394-978f-1a12-b38e-2f3ab8ad02f7@huawei.com \
--to=yangyingliang@huawei.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox