From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1BDC05027 for ; Fri, 20 Jan 2023 08:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbjATIX6 (ORCPT ); Fri, 20 Jan 2023 03:23:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjATIX6 (ORCPT ); Fri, 20 Jan 2023 03:23:58 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF8D26C13C for ; Fri, 20 Jan 2023 00:23:56 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id d4-20020a05600c3ac400b003db1de2aef0so3067067wms.2 for ; Fri, 20 Jan 2023 00:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FgloWXFLaFs9lmJG0fPOaTpoYd54+C3xSVgrFaunkT0=; b=MHCGfgilU6ydlCFAZY5JatZkaD2pp/zBsnjj10yE611kJslbTuldF2Ay27aBDL9Wyx A0alK4w+msJgKduZqXDeuSLDUFetGDQIsrJ9KC49tzY9DyJJpGPytDhxbQ4vSZPsN+Lb EGle3WyRPf4lG39x9nGSf9yjOlEJeQXAnZvXApuMwdEurDEIPtpb66uqcajWVfWErmWl 0wzy4li7yElaB6e08Loqd/Hle7PBAU4htngF4xusf3TKT8NByPEvLB3NNGds5+kiHu45 kG5wx9e1oJhcCOEbjSDBxX+JE/joyng7hUmGriz6Q1LEE+BGC8YCQriTXmu9zvbKYX9a CRMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FgloWXFLaFs9lmJG0fPOaTpoYd54+C3xSVgrFaunkT0=; b=8Al6QzzbJhTO/7zi5nkyChgqHxELk5uxvSiQRB67MA05Xt7jfg3h9MevokrbEtzPVt pLwoM5FVQXSBOljgxbX9mpAhe8rXrT1TViCffBXWGXwbobJVJWHVRn37UCi5AhIGwosO RaduvHBGFkycZpk0rJWVGyzvf2iA1+PjxR0DMP+wHk7Atz6EfhR+w47wMZYPVuEQOuBx FW0NOcper7fXWOk/7Oru1pGJJMzw/JipgqoWy+H8vFHs0YBLiDvj4qoT6Qsd5dibNK+n 36LK5EkBIl4rAL2YMmW43tGCm9FOg1slfLzX/fx6LwBruLLIiKAJjliVd6/sZmZ9W3vv 5nzA== X-Gm-Message-State: AFqh2krObMLIyvJwW4hi6Ax2bbCK/ZFa4P/0fdga1zW2B5Bf6bwrDv22 sRTyUWpJwkNOpM1tNzshnkwoFA== X-Google-Smtp-Source: AMrXdXtzKTRjLx4Z1Jr2/H8s3PWQANcY3pEfPSsg7PLeLmP7E+lFoP4RTADLwa6KxNEDcah3ADdPoQ== X-Received: by 2002:a05:600c:3b82:b0:3d2:392b:3165 with SMTP id n2-20020a05600c3b8200b003d2392b3165mr13346564wms.12.1674203035433; Fri, 20 Jan 2023 00:23:55 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id o28-20020a05600c511c00b003dab40f9eafsm1608605wms.35.2023.01.20.00.23.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 00:23:55 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 09:23:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2 2/2] spi: spidev: add new mediatek support Content-Language: en-US To: Alexandre Mergnat , Mark Brown Cc: Matthias Brugger , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Amjad Ouled-Ameur , linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org References: <20230118-mt8365-spi-support-v2-0-be3ac97a28c6@baylibre.com> <20230118-mt8365-spi-support-v2-2-be3ac97a28c6@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On 19/01/2023 20:30, Alexandre Mergnat wrote: > Le jeu. 19 janv. 2023 à 18:36, Mark Brown a écrit : >> >> On Thu, Jan 19, 2023 at 06:28:20PM +0100, Alexandre Mergnat wrote: >>> Add the "mediatek,genio" compatible string to support Mediatek >>> SPI controller on the genio boards. >> >> All my previous review comments stand, please don't ignore review >> feedback. > > Hi Mark, > > Yes sorry about that, I wasn't aware that I've some feedback when I > sent V2 for a quickfix. > > I will take care about your comment: > >> We need a matching update to the binding document. >> >> This does also seem like a terribly generic name - Google >> suggests that this is actually a series of numbered products (eg, >> Genio 700), perhaps we should be using the specific numbers here? >> I guess users would care which they're talking to. It really >> parses as being "generic I/O" which would be an end run around >> describing the actual product though it's not actually that. > > Is there a binding documentation for spidev ? I didn't find it. > > My understanding is to have something more specific like: > compatible = "mediatek,genio350" > Or maybe use the SoC name, to be aligned with the DTS ? > compatible = "mediatek,spi-mt8365" This should be specific compatible for your device attached over SPI. If you have there "Genio 350", then the first. Compatible can be documented in its own binding or in trivial-devices (I sent a patch for existing ones). Best regards, Krzysztof