linux-spi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "James Clark" <james.clark@linaro.org>, "Frank Li" <Frank.li@nxp.com>
Cc: "Vladimir Oltean" <olteanv@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	"Larisa Grigore" <larisa.grigore@nxp.com>,
	"Christoph Hellwig" <hch@lst.de>,
	linux-spi@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] spi: spi-fsl-dspi: Use non-coherent memory for DMA
Date: Thu, 26 Jun 2025 11:38:46 +0200	[thread overview]
Message-ID: <a7c71ee8-0931-4af3-a68f-3f21fea840d3@app.fastmail.com> (raw)
In-Reply-To: <6fe9eebc-b050-4b12-a28b-e2f0bcc707e2@linaro.org>

On Thu, Jun 26, 2025, at 11:14, James Clark wrote:
> On 25/06/2025 4:04 pm, Frank Li wrote:
>>
>> The cover letter will be lost after patch merge. When someone run git log
>> after some year later, they need know why need this change , what purpose ...
>> 
> I somewhat disagree with this. Usually maintainers add a 'Link:' to the 
> mailing list when applying patches, so the cover letter shouldn't be 
> lost. And these particular performance test results are short lived, in 
> several years time other things may have changed. The performance is 
> related to a specific device and the state of the rest of the kernel at 
> this time. Additionally, I mentioned that it's the combination of two 
> commits. In order to put figures on this commit message I would have to 
> run another set of tests with only this commit and not the one to 
> increase the buffer size which comes after. I did consider reversing the 
> order of them to do this, but it wasn't straightforward, and I really 
> didn't think it was worth the effort when I can just put the figures on 
> the cover letter.

If you submit your changes as a pull request for inclusion, the
common solution is to put the cover letter into the signed tag,
which then gets used as both the description in 'git request-pull'
and in the merge commit.

See e.g. commit 5b31d2d81a4b ("spi: sh-msiof: Transfer size
improvements and I2S") for how a similar series on another driver
shows up in the git log.

    Arnd

  reply	other threads:[~2025-06-26  9:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 10:35 [PATCH v3 0/6] spi: spi-fsl-dspi: Target mode improvements James Clark
2025-06-24 10:35 ` [PATCH v3 1/6] spi: spi-fsl-dspi: Clear completion counter before initiating transfer James Clark
2025-06-24 15:58   ` Frank Li
2025-06-25  9:52     ` James Clark
2025-06-24 10:35 ` [PATCH v3 2/6] spi: spi-fsl-dspi: Store status directly in cur_msg->status James Clark
2025-06-24 16:18   ` Frank Li
2025-06-25  9:56     ` James Clark
2025-06-24 10:35 ` [PATCH v3 3/6] spi: spi-fsl-dspi: Stub out DMA functions James Clark
2025-06-24 16:29   ` Frank Li
2025-06-24 17:16     ` Arnd Bergmann
2025-06-25  9:19       ` James Clark
2025-06-25 10:00         ` Arnd Bergmann
2025-06-25 10:19           ` James Clark
2025-06-25 10:54             ` Arnd Bergmann
2025-06-26 10:04               ` James Clark
2025-06-26 11:34                 ` Mark Brown
2025-06-25  5:25   ` kernel test robot
2025-06-24 10:35 ` [PATCH v3 4/6] spi: spi-fsl-dspi: Use non-coherent memory for DMA James Clark
2025-06-24 16:39   ` Frank Li
2025-06-25  9:00     ` James Clark
2025-06-25 15:04       ` Frank Li
2025-06-26  9:14         ` James Clark
2025-06-26  9:38           ` Arnd Bergmann [this message]
2025-06-26 11:16             ` Mark Brown
2025-06-24 10:35 ` [PATCH v3 5/6] spi: spi-fsl-dspi: Increase DMA buffer size James Clark
2025-06-24 10:35 ` [PATCH v3 6/6] spi: spi-fsl-dspi: Report FIFO overflows as errors James Clark
2025-06-24 16:50   ` Frank Li
2025-06-25 10:09     ` James Clark
2025-06-25 14:55       ` Frank Li
2025-06-27  8:52         ` James Clark
2025-06-25  7:10   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7c71ee8-0931-4af3-a68f-3f21fea840d3@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Frank.li@nxp.com \
    --cc=broonie@kernel.org \
    --cc=hch@lst.de \
    --cc=imx@lists.linux.dev \
    --cc=james.clark@linaro.org \
    --cc=larisa.grigore@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).