From: Frank Li <Frank.li@nxp.com>
To: carlos.song@nxp.com
Cc: broonie@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: imx: support SPI target PIO mode for IMX51_ECSPI
Date: Fri, 24 Oct 2025 11:30:39 -0400 [thread overview]
Message-ID: <aPubn5XQCHDLvsHq@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20251024055243.408461-1-carlos.song@nxp.com>
On Fri, Oct 24, 2025 at 01:52:43PM +0800, carlos.song@nxp.com wrote:
> From: Carlos Song <carlos.song@nxp.com>
>
> IMX51_ECSPI and IMX53_ECSPI both has target mode, but now PIO target mode
> is only supported for IMX53_ECSPI.
>
> Support target PIO mode for IMX51_ECSPI. It can share the same functions
> for data transmission and reception in target mode with IMX53_ECSPI. So
> remove target mode restriction only for IMX53_ECSPI and move target max
> transfer len to devtype_data of IMX53_ECSPI and IMX51_ECSPI to improve
> readability.
Look like whole patch have not touch PIO mode and DMA mode at all.
spi: imx: add i.MX51 ECSPI target mode support.
ECSPI in i.MX51 and i.MX53 support target mode. Current code only support
i.MX53. Remove is_imx53_ecspi() check for target mode to support i.MX51.
Add target_max_transfer_bytes should be new patch. Any difference between
SoCs? if all the same, needn't this movement.
Frank
>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> ---
> drivers/spi/spi-imx.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 6eb4bfb7be4a..cd40db61d8d1 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -85,6 +85,7 @@ struct spi_imx_devtype_data {
> void (*disable)(struct spi_imx_data *spi_imx);
> bool has_dmamode;
> bool has_targetmode;
> + int target_max_transfer_bytes;
> unsigned int fifo_size;
> bool dynamic_burst;
> /*
> @@ -594,7 +595,7 @@ static int mx51_ecspi_prepare_message(struct spi_imx_data *spi_imx,
> * is not functional for imx53 Soc, config SPI burst completed when
> * BURST_LENGTH + 1 bits are received
> */
> - if (spi_imx->target_mode && is_imx53_ecspi(spi_imx))
> + if (spi_imx->target_mode)
> cfg &= ~MX51_ECSPI_CONFIG_SBBCTRL(channel);
> else
> cfg |= MX51_ECSPI_CONFIG_SBBCTRL(channel);
> @@ -682,7 +683,7 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
>
> /* Clear BL field and set the right value */
> ctrl &= ~MX51_ECSPI_CTRL_BL_MASK;
> - if (spi_imx->target_mode && is_imx53_ecspi(spi_imx))
> + if (spi_imx->target_mode)
> ctrl |= (spi_imx->target_burst * 8 - 1)
> << MX51_ECSPI_CTRL_BL_OFFSET;
> else {
> @@ -1140,6 +1141,7 @@ static struct spi_imx_devtype_data imx51_ecspi_devtype_data = {
> .has_dmamode = true,
> .dynamic_burst = true,
> .has_targetmode = true,
> + .target_max_transfer_bytes = MX53_MAX_TRANSFER_BYTES,
> .disable = mx51_ecspi_disable,
> .devtype = IMX51_ECSPI,
> };
> @@ -1154,6 +1156,7 @@ static struct spi_imx_devtype_data imx53_ecspi_devtype_data = {
> .fifo_size = 64,
> .has_dmamode = true,
> .has_targetmode = true,
> + .target_max_transfer_bytes = MX53_MAX_TRANSFER_BYTES,
> .disable = mx51_ecspi_disable,
> .devtype = IMX53_ECSPI,
> };
> @@ -1170,6 +1173,7 @@ static struct spi_imx_devtype_data imx6ul_ecspi_devtype_data = {
> .has_dmamode = true,
> .dynamic_burst = true,
> .has_targetmode = true,
> + .target_max_transfer_bytes = MX53_MAX_TRANSFER_BYTES,
> .tx_glitch_fixed = true,
> .disable = mx51_ecspi_disable,
> .devtype = IMX51_ECSPI,
> @@ -1375,7 +1379,7 @@ static int spi_imx_setupxfer(struct spi_device *spi,
> spi_imx->rx_only = ((t->tx_buf == NULL)
> || (t->tx_buf == spi->controller->dummy_tx));
>
> - if (is_imx53_ecspi(spi_imx) && spi_imx->target_mode) {
> + if (spi_imx->target_mode) {
> spi_imx->rx = mx53_ecspi_rx_target;
> spi_imx->tx = mx53_ecspi_tx_target;
> spi_imx->target_burst = t->len;
> @@ -1649,8 +1653,7 @@ static int spi_imx_pio_transfer_target(struct spi_device *spi,
> struct spi_imx_data *spi_imx = spi_controller_get_devdata(spi->controller);
> int ret = 0;
>
> - if (is_imx53_ecspi(spi_imx) &&
> - transfer->len > MX53_MAX_TRANSFER_BYTES) {
> + if (transfer->len > spi_imx->devtype_data->target_max_transfer_bytes) {
> dev_err(&spi->dev, "Transaction too big, max size is %d bytes\n",
> MX53_MAX_TRANSFER_BYTES);
> return -EMSGSIZE;
> --
> 2.34.1
>
prev parent reply other threads:[~2025-10-24 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 5:52 [PATCH] spi: imx: support SPI target PIO mode for IMX51_ECSPI carlos.song
2025-10-24 15:30 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPubn5XQCHDLvsHq@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=carlos.song@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).