From: Mark Brown <broonie@kernel.org>
To: Hang Zhou <929513338@qq.com>
Cc: jonas.gorski@gmail.com, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: bcm63xx: fix premature CS deassertion on RX-only transactions
Date: Mon, 17 Nov 2025 17:29:30 +0000 [thread overview]
Message-ID: <aRtbeo0pFSFQCR9d@sirena.co.uk> (raw)
In-Reply-To: <tencent_AD45099B2ACD2FBFA150B8AF87074644C705@qq.com>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
On Tue, Nov 18, 2025 at 03:53:38AM +1100, Hang Zhou wrote:
> I initially picked 0xFF because in most case, the SPI bus is high when it's idle, but in practice 0x00 works just as well here.
> If you prefer, I'm happy to switch the dummy value to 0x00 for consistency and respin this as v3.
No, it's OK - if this hardware defaults to keeing the signal high then
0xff is a better choice. Most hardware defaults to keeping the line
low.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-11-17 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 14:08 [PATCH v2] spi: bcm63xx: fix premature CS deassertion on RX-only transactions Hang Zhou
2025-11-16 21:45 ` Mark Brown
2025-11-17 16:53 ` Hang Zhou
2025-11-17 17:29 ` Mark Brown [this message]
2025-11-20 9:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRtbeo0pFSFQCR9d@sirena.co.uk \
--to=broonie@kernel.org \
--cc=929513338@qq.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox