From: Mark Brown <broonie@kernel.org>
To: Anurag Dutta <a-dutta@ti.com>
Cc: grmoore@opensource.altera.com, nm@ti.com, francesco@dolcini.it,
s-vadapalli@ti.com, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, gehariprasath@ti.com,
u-kumar1@ti.com
Subject: Re: [PATCH 2/2] spi: cadence-quadspi: Fix clock disable on probe failure path
Date: Fri, 12 Dec 2025 17:44:15 +0900 [thread overview]
Message-ID: <aTvV31zHFV30tR-N@sirena.co.uk> (raw)
In-Reply-To: <20251212072312.2711806-3-a-dutta@ti.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Fri, Dec 12, 2025 at 12:53:12PM +0530, Anurag Dutta wrote:
> When cqspi_request_mmap_dma() returns -EPROBE_DEFER after runtime PM
> is enabled, the error path calls clk_disable_unprepare() on an already
> disabled clock, causing an imbalance.
>
> Use pm_runtime_get_sync() to increment the usage counter and resume the
> device. This prevents runtime_suspend() from being invoked and causing
> a double clock disable.
Thanks - this is working for me with a hack to trigger the issue,
hopefully others seeing the issue in real scenarios can confirm.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-12-12 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 7:23 [PATCH 0/2] spi: cadence-quadspi: Fix probe error path and logging Anurag Dutta
2025-12-12 7:23 ` [PATCH 1/2] spi: cadence-quadspi: Add error logging for DMA request failure Anurag Dutta
2025-12-12 7:23 ` [PATCH 2/2] spi: cadence-quadspi: Fix clock disable on probe failure path Anurag Dutta
2025-12-12 8:44 ` Mark Brown [this message]
2025-12-15 18:13 ` Nishanth Menon
2025-12-18 9:32 ` [PATCH 0/2] spi: cadence-quadspi: Fix probe error path and logging Mark Brown
2025-12-23 17:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTvV31zHFV30tR-N@sirena.co.uk \
--to=broonie@kernel.org \
--cc=a-dutta@ti.com \
--cc=francesco@dolcini.it \
--cc=gehariprasath@ti.com \
--cc=grmoore@opensource.altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
--cc=s-vadapalli@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox